[Milky] Suppress the IL3050 Risk

Author: Linwenxuan04

Lagrange.Milky/Extension/BotContextExtension.cs

@@ -7,6 +7,7 @@ namespace Lagrange.Milky.Extension;
 
 [UnconditionalSuppressMessage("Trimming", "IL2026")]
 [UnconditionalSuppressMessage("Trimming", "IL2075")]
+[UnconditionalSuppressMessage("Trimming", "IL3050", Justification = "There is no generic method in this code.")]
 public static class BotContextExtension
 {
     private delegate ValueTask<(int RetCode, string Extra, ReadOnlyMemory<byte> Data)> SendPacketDelegate(BotContext bot, string cmd, int sequence, byte[] data);
@@ -16,21 +17,18 @@ public static class BotContextExtension
     private const string EncryptTypeFullName = "Lagrange.Core.Internal.Packets.Struct.EncryptType";
     private const string ServiceAttributeFullName = "Lagrange.Core.Internal.Services.ServiceAttribute";
 
-    private static readonly Lazy<SendPacketDelegate> _sendPacket = new(() =>
+    private static readonly Lazy<SendPacketDelegate> SendPacketDelegateGenerator = new(() =>
     {
-        var coreAssembly = Assembly.GetAssembly(typeof(BotContext));
-        if (coreAssembly == null) throw new Exception("Assembly(Lagrange.Core) not found");
+        var coreAssembly = Assembly.GetAssembly(typeof(BotContext)) ??  throw new Exception("Assembly(Lagrange.Core) not found");
         Type ssoPacketType;
         {
             var type = coreAssembly.GetType(SsoPacketFullName);
-            if (type == null) throw new Exception($"Type({SsoPacketFullName}) not found");
-            ssoPacketType = type;
+            ssoPacketType = type ?? throw new Exception($"Type({SsoPacketFullName}) not found");
         }
         Type serviceAttributeType;
         {
             var type = coreAssembly.GetType(ServiceAttributeFullName);
-            if (type == null) throw new Exception($"Type({ServiceAttributeFullName}) not found");
-            serviceAttributeType = type;
+            serviceAttributeType = type ?? throw new Exception($"Type({ServiceAttributeFullName}) not found");
         }
 
         // 
@@ -46,39 +44,26 @@ public static class BotContextExtension
             // Create SsoPacket
             NewExpression packet;
             {
-                var ctor = ssoPacketType.GetConstructor(
-                    [typeof(string), typeof(ReadOnlyMemory<byte>), typeof(int)]
-                );
-                if (ctor == null)
-                {
-                    throw new Exception($"Ctor({SsoPacketFullName}(string, ReadOnlyMemory<byte>, int)) not found");
-                }
-                packet = Expression.New(ctor, [cmd, dataInput, sequence]);
+                var ctor = ssoPacketType.GetConstructor([typeof(string), typeof(ReadOnlyMemory<byte>), typeof(int)]) ?? throw new Exception($"Ctor({SsoPacketFullName}(string, ReadOnlyMemory<byte>, int)) not found");
+                
+                packet = Expression.New(ctor, cmd, dataInput, sequence);
             }
 
             // Create ServiceAttribute
             NewExpression options;
             {
-                var requestTypeType = coreAssembly.GetType(RequestTypeFullName);
-                if (requestTypeType == null) throw new Exception($"Type({RequestTypeFullName}) not found");
+                var requestTypeType = coreAssembly.GetType(RequestTypeFullName) ?? throw new Exception($"Type({RequestTypeFullName}) not found");
                 var requestType = Expression.Constant(Enum.Parse(requestTypeType, "D2Auth"));
 
-                var encryptTypeType = coreAssembly.GetType(EncryptTypeFullName);
-                if (encryptTypeType == null) throw new Exception($"Type({EncryptTypeFullName}) not found");
+                var encryptTypeType = coreAssembly.GetType(EncryptTypeFullName) ?? throw new Exception($"Type({EncryptTypeFullName}) not found");
                 var encryptType = Expression.Constant(Enum.Parse(encryptTypeType, "EncryptD2Key"));
 
-                var ctor = serviceAttributeType.GetConstructor(
-                    [typeof(string), requestTypeType, encryptTypeType]
-                );
-                if (ctor == null)
-                {
-                    throw new Exception($"Ctor({ServiceAttributeFullName}(string, RequestType, EncryptType)) not found");
-                }
-                options = Expression.New(ctor, [cmd, requestType, encryptType]);
+                var ctor = serviceAttributeType.GetConstructor([typeof(string), requestTypeType, encryptTypeType]) ?? throw new Exception($"Ctor({ServiceAttributeFullName}(string, RequestType, EncryptType)) not found");
+                options = Expression.New(ctor, cmd, requestType, encryptType);
             }
 
             // Call SendPacket
-            var vt = Expression.Call(context, "SendPacket", [], [packet, options]);
+            var vt = Expression.Call(context, "SendPacket", [], packet, options);
 
             var taskResult = Expression.Property(vt, "Result");
 
@@ -89,22 +74,19 @@ public static class BotContextExtension
             NewExpression result;
             {
                 var type = typeof((int, string, ReadOnlyMemory<byte>));
-                var ctor = type.GetConstructor([typeof(int), typeof(string), typeof(ReadOnlyMemory<byte>)]);
-                if (ctor == null) throw new Exception("Ctor((int, string, ReadOnlyMemory<byte>)) not found");
-                var newResult = Expression.New(ctor, [retcode, extra, dataResult]);
+                var ctor = type.GetConstructor([typeof(int), typeof(string), typeof(ReadOnlyMemory<byte>)]) ?? throw new Exception("Ctor((int, string, ReadOnlyMemory<byte>)) not found");
+                var newResult = Expression.New(ctor, retcode, extra, dataResult);
+                var method = typeof(ValueTask<(int, string, ReadOnlyMemory<byte>)>).GetConstructor([type]) ?? throw new Exception("Ctor(ValueTask((int, string, ReadOnlyMemory<byte>))) not found");
 
-                var method = typeof(ValueTask<(int, string, ReadOnlyMemory<byte>)>).GetConstructor([type]);
-                if (method == null) throw new Exception("Ctor(ValueTask((int, string, ReadOnlyMemory<byte>))) not found");
-
-                result = Expression.New(method, [newResult]);
+                result = Expression.New(method, newResult);
             }
 
-            return Expression.Lambda<SendPacketDelegate>(result, [bot, cmd, sequence, dataInput]).Compile();
+            return Expression.Lambda<SendPacketDelegate>(result, bot, cmd, sequence, dataInput).Compile();
         }
     });
 
     public static ValueTask<(int RetCode, string Extra, ReadOnlyMemory<byte> Data)> SendPacket(this BotContext bot, string cmd, int sequence, byte[] data)
     {
-        return _sendPacket.Value(bot, cmd, sequence, data);
+        return SendPacketDelegateGenerator.Value(bot, cmd, sequence, data);
     }
 }