[Proto] Make Lookup class fully rva-static#100
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Lookup tables used by ProtoReader varint decoding to be represented as RVA-backed data (via ReadOnlySpan/collection expressions) rather than runtime-initialized arrays, aiming to enable better JIT optimization.
Changes:
- Replaced
Lookup.DoubleVecruntime initialization with an RVA-backedReadOnlySpan<Vector128<sbyte>>over a byte blob. - Replaced
Lookup.DoubleStep1with an RVA-backed byte blob and aMemoryMarshal.Cast-produced span for lookup entries. - Updated
ProtoReader.DecodeTwo32VarIntUnsafeto index the new span-based tables and retrieve shuffle vectors viaUnsafe.Add.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Lagrange.Proto/Primitives/ProtoReader.cs | Switched lookup/shuffle table access to the new span-based Lookup representation. |
| Lagrange.Proto/Primitives/Lookup.cs | Converted decode lookup tables to RVA-backed ReadOnlySpan data and exposed them via MemoryMarshal.Cast. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Linwenxuan04
approved these changes
Mar 20, 2026
Bemly
pushed a commit
to Bemly/CharonAnchor
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
Lookupclass fully rva-static. This gives the JIT more opportunities to optimize.