[Core] Allow SignProvider to throw exceptions#107
Merged
Linwenxuan04 merged 2 commits intoApr 9, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes signing behavior so BotSignProvider implementations can surface exceptions instead of swallowing them, and updates core packet send/refresh flows to handle those failures more explicitly.
Changes:
- Remove broad try/catch blocks in multiple
BotSignProviderimplementations so failures can propagate. - Add exception handling around
PacketContext.SendPacketbackground send work to complete the awaitingValueTaskwith an error. - Wrap
wtlogin.exchange_emprefresh timer logic in a try/catch to avoid unhandled exceptions during periodic refresh.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Lagrange.Milky/Utility/Signer.cs | Stops swallowing signer HTTP/serialization errors so exceptions can propagate. |
| Lagrange.Core/Internal/Logic/WtExchangeLogic.cs | Adds defensive try/catch around periodic ExchangeEmp refresh execution. |
| Lagrange.Core/Internal/Context/PacketContext.cs | Catches signing/packing/sending exceptions and completes the pending request task exceptionally. |
| Lagrange.Core/Common/BotSignProvider.cs | Default (non-Android) sign provider now allows exceptions to propagate. |
| Lagrange.Core/Common/AndroidBotSignProvider.cs | Android sign/energy/debug calls now allow exceptions to propagate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Linwenxuan04
deleted the
noirhare/allow-sign-provider-to-throw-exceptions
branch
Bemly
pushed a commit
to Bemly/CharonAnchor
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.