[Core] Implemented FetchGroupNotifications and its required APIs#33
Merged
Conversation
1. Implemented FetchStranger via uin and uid 2. Implemented FetchGroupNotifications 3. Extended BotStranger 4. Make package processing asynchronous In order to continue sending packets while parsing the packet 5. Created a cache for BotStranger
NoirHare
changed the title
NoirHare
approved these changes
Aug 14, 2025
Bemly
pushed a commit
to Bemly/CharonAnchor
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the review. Please feel free to point out any inaccuracies.
Specific modifications:
The modification in ClientListener.cs was necessitated by the transition of the packet handler to asynchronous processing (SsoPacket.cs), requiring packet copying to prevent modification during subsequent packet handling.
This shift to asynchronous processing in SsoPacket.cs was implemented because the logic in FetchGroupNotificationsService.cs requires sending additional packets during packet processing. Crucially, since the
ManualResetValueTaskSourceCore<>operates synchronously by default, synchronous execution would cause the sent packets to be unable to receive responses due to Socket blocking, resulting in a deadlock from mutual blocking.In BotGroupNotificationBase.cs, while utilizing concrete implementation classes to differentiate notification types, a variable indicating the type is still stored to facilitate subsequent notification processing. This design enables rapid configuration during handling procedures where type codes are required.