[Core & Milky] Implement friend_request event#39
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for the friend_request event, adding the ability to detect and handle incoming friend requests in the Lagrange chat system. The implementation spans both the Core and Milky components, providing end-to-end event processing from protocol-level packet handling to JSON serialization for external consumers.
Key changes:
- Added protocol-level packet structures and parsing for friend request notifications
- Implemented event data classes and conversion utilities for friend request events
- Extended the event service to handle and serialize friend request events for external consumption
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Lagrange.Core/Internal/Packets/Notify/FriendRequest.cs | Defines protobuf packet structures for friend request notifications |
| Lagrange.Core/Events/EventArgs/BotFriendRequestEvent.cs | Core event class containing friend request data |
| Lagrange.Core/Internal/Logic/PushLogic.cs | Adds packet parsing logic for Event0x210 friend request notifications |
| Lagrange.Milky/Entity/Event/FriendRequestEvent.cs | JSON-serializable event classes for external API |
| Lagrange.Milky/Utility/EntityConvert.Event.cs | Conversion logic from core events to Milky events |
| Lagrange.Milky/Event/EventService.cs | Event handler registration and processing for friend requests |
| Lagrange.Milky/Utility/JsonUtility.cs | JSON serialization context registration for friend request events |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
NoirHare
approved these changes
Aug 18, 2025
Bemly
pushed a commit
to Bemly/CharonAnchor
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.