Skip to content

[Core & Milky] Implement friend_request event#39

Merged
Wesley-Young merged 4 commits into
LagrangeDev:mainfrom
Szzrain:friend-request
Aug 18, 2025
Merged

[Core & Milky] Implement friend_request event#39
Wesley-Young merged 4 commits into
LagrangeDev:mainfrom
Szzrain:friend-request

Conversation

@Szzrain
Copy link
Copy Markdown
Contributor

@Szzrain Szzrain commented Aug 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 18, 2025 02:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for the friend_request event, adding the ability to detect and handle incoming friend requests in the Lagrange chat system. The implementation spans both the Core and Milky components, providing end-to-end event processing from protocol-level packet handling to JSON serialization for external consumers.

Key changes:

  • Added protocol-level packet structures and parsing for friend request notifications
  • Implemented event data classes and conversion utilities for friend request events
  • Extended the event service to handle and serialize friend request events for external consumption

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Lagrange.Core/Internal/Packets/Notify/FriendRequest.cs Defines protobuf packet structures for friend request notifications
Lagrange.Core/Events/EventArgs/BotFriendRequestEvent.cs Core event class containing friend request data
Lagrange.Core/Internal/Logic/PushLogic.cs Adds packet parsing logic for Event0x210 friend request notifications
Lagrange.Milky/Entity/Event/FriendRequestEvent.cs JSON-serializable event classes for external API
Lagrange.Milky/Utility/EntityConvert.Event.cs Conversion logic from core events to Milky events
Lagrange.Milky/Event/EventService.cs Event handler registration and processing for friend requests
Lagrange.Milky/Utility/JsonUtility.cs JSON serialization context registration for friend request events

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@Wesley-Young Wesley-Young self-requested a review August 18, 2025 02:37
Comment thread Lagrange.Core/Internal/Logic/PushLogic.cs
@NoirHare NoirHare requested review from NoirHare and removed request for NoirHare August 18, 2025 02:53
@Wesley-Young Wesley-Young merged commit 323e8f1 into LagrangeDev:main Aug 18, 2025
9 checks passed
@Szzrain Szzrain deleted the friend-request branch August 18, 2025 02:57
Bemly pushed a commit to Bemly/CharonAnchor that referenced this pull request May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants