[Core & Milky] Implement GroupFileEntity and file Segment#65
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for group file messages by adding a GroupFileEntity in the Core library and corresponding FileIncomingSegment in the Milky library. The implementation includes protobuf message definitions for parsing group file data and conversion logic to handle file segments.
- Added
GroupFileEntityclass to handle group file message parsing and representation - Implemented
FileIncomingSegmentfor the Milky API with JSON serialization support - Added protobuf definitions for parsing group file metadata from message elements
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Lagrange.Core/Message/Entities/GroupFileEntity.cs | New entity class for group file messages with parsing logic |
| Lagrange.Core/Internal/Packets/Message/Extra.cs | Added protobuf classes for group file metadata structure |
| Lagrange.Core/Internal/Packets/Message/Elem.cs | Added TransElem protobuf class for element parsing |
| Lagrange.Milky/Entity/Segment/FileSegment.cs | New file segment classes for API representation |
| Lagrange.Milky/Utility/EntityConvert.Segment.cs | Added conversion from GroupFileEntity to FileIncomingSegment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KusaGumina
approved these changes
Sep 20, 2025
Bemly
pushed a commit
to Bemly/CharonAnchor
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.