Fix bad sanitisation

Author: Lamparter

src/features/Riverside.CompilerPlatform.Features.Swagger/KiotaEngine.Methods.cs

@@ -1,4 +1,5 @@
-using System.Text;
+using Riverside.CompilerPlatform.Helpers;
+using System.Text;
 
 namespace Riverside.CompilerPlatform.Features.Swagger;
 
@@ -13,19 +14,19 @@ partial class KiotaEngine
 	/// </returns>
 	public override string ToString()
 	{
-		var command = new StringBuilder().Append("kiota generate");
+		var command = new StringBuilder().Append("generate");
 
 		if (!string.IsNullOrWhiteSpace(Path))
 		{
-			command.Append($" --openapi {Path}");
+			command.Append($" --openapi {SanitizationHelpers.EscapeArg(Path!)}");
 		}
 		if (!string.IsNullOrWhiteSpace(Manifest))
 		{
-			command.Append($" --manifest {Manifest}");
+			command.Append($" --manifest {SanitizationHelpers.EscapeArg(Manifest!)}");
 		}
 		if (!string.IsNullOrWhiteSpace(Output))
 		{
-			command.Append($" --output {Output}");
+			command.Append($" --output {SanitizationHelpers.EscapeArg(Output!)}");
 		}
 		command.Append($" --language {Language}");
 		if (!string.IsNullOrWhiteSpace(ClassName))
@@ -56,68 +57,68 @@ public override string ToString()
 		{
 			command.Append($" --additional-data {AdditionalData}");
 		}
-		if (Serializer is not null)
+		if (Serializer is not null && Serializer.Length > 0)
 		{
 			var serializers = new StringBuilder().Append(" --serializer ");
 			foreach (var serializer in Serializer)
 			{
 				serializers.Append(serializer + "|");
 			}
-			serializers.Remove(serializers.Length, 1); // remove final '|' char
+			serializers.Remove(serializers.Length - 1, 1); // remove final '|' char
 			command.Append(serializers.ToString());
 		}
-		if (Deserializer is not null)
+		if (Deserializer is not null && Deserializer.Length > 0)
 		{
 			var deserializers = new StringBuilder().Append(" --deserializer ");
 			foreach (var deserializer in Deserializer)
 			{
 				deserializers.Append(deserializer + "|");
 			}
-			deserializers.Remove(deserializers.Length, 1); // remove final '|' char
+			deserializers.Remove(deserializers.Length - 1, 1); // remove final '|' char
 			command.Append(deserializers.ToString());
 		}
 		if (CleanOutput is not null)
 		{
 			command.Append($" --clean-output {CleanOutput}");
 		}
-		if (StructuredMimeTypes is not null)
+		if (StructuredMimeTypes is not null && StructuredMimeTypes.Length > 0)
 		{
 			var structuredMimeTypes = new StringBuilder().Append(" --structured-mime-types ");
 			foreach (var structuredMimeType in StructuredMimeTypes)
 			{
 				structuredMimeTypes.Append(structuredMimeType + "|");
 			}
-			structuredMimeTypes.Remove(structuredMimeTypes.Length, 1); // remove final '|' char
+			structuredMimeTypes.Remove(structuredMimeTypes.Length - 1, 1); // remove final '|' char
 			command.Append(structuredMimeTypes.ToString());
 		}
-		if (IncludePath is not null)
+		if (IncludePath is not null && IncludePath.Length > 0)
 		{
 			var includePaths = new StringBuilder().Append(" --include-path ");
 			foreach (var includePath in IncludePath)
 			{
 				includePaths.Append(includePath + "|");
 			}
-			includePaths.Remove(includePaths.Length, 1); // remove final '|' char
+			includePaths.Remove(includePaths.Length - 1, 1); // remove final '|' char
 			command.Append(includePaths.ToString());
 		}
-		if (ExcludePath is not null)
+		if (ExcludePath is not null && ExcludePath.Length > 0)
 		{
 			var excludePaths = new StringBuilder().Append(" --exclude-path ");
 			foreach (var excludePath in ExcludePath)
 			{
 				excludePaths.Append(excludePath + "|");
 			}
-			excludePaths.Remove(excludePaths.Length, 1); // remove final '|' char
+			excludePaths.Remove(excludePaths.Length - 1, 1); // remove final '|' char
 			command.Append(excludePaths.ToString());
 		}
-		if (DisableValidationRules is not null)
+		if (DisableValidationRules is not null && DisableValidationRules.Length > 0)
 		{
 			var disableValidationRules = new StringBuilder().Append(" --disable-validation-rules ");
 			foreach (var disableValidationRule in DisableValidationRules)
 			{
 				disableValidationRules.Append(disableValidationRule + "|");
 			}
-			disableValidationRules.Remove(disableValidationRules.Length, 1); // remove final '|' char
+			disableValidationRules.Remove(disableValidationRules.Length - 1, 1); // remove final '|' char
 			command.Append(disableValidationRules.ToString());
 		}
 		if (ClearCache is not null)

src/roslyn/Riverside.CompilerPlatform.Extensions/Helpers/SanitizationHelpers.cs

@@ -36,7 +36,6 @@ public static string Sanitize(string s)
 	/// <param name="arg">The argument to escape.</param>
 	/// <returns>A string containing the escaped argument, suitable for use in a command-line context.</returns>
 	/// <exception cref="ArgumentNullException">Thrown if <paramref name="arg"/> is null.</exception>
-	[NotMyCode] // from the internet
 	public static string EscapeArg(string arg)
 	{
 		if (arg == null)