fix smells

Author: Apfelwurm

NetEvent/Server.Tests/SystemModuleTest.cs

@@ -95,7 +95,7 @@ public async Task PostOrganizationHandler_Error_Test()
         }
 
         [Fact]
-        public async Task GetSystemInfoVersionsSetted_Success_Test()
+        public async Task GetSystemInfoVersionsSetted_Test()
         {
             // Arrange
             AppDomain currentDomain = AppDomain.CurrentDomain;
@@ -125,10 +125,9 @@ public async Task GetSystemInfoVersionsSetted_Success_Test()
         }
 
         [Fact]
-        public async Task GetSystemInfoVersionsNotSetted_Success_Test()
+        public async Task GetSystemInfoVersionsNotSetted_Test()
         {
             // Arrange
-            AppDomain currentDomain = AppDomain.CurrentDomain;
             Environment.SetEnvironmentVariable("BUILDNODE", string.Empty);
             Environment.SetEnvironmentVariable("BUILDID", string.Empty);
             Environment.SetEnvironmentVariable("BUILDNUMBER", string.Empty);

NetEvent/Server/Modules/System/Endpoints/GetSystemInfo/GetSystemInfoHandler.cs

@@ -28,7 +28,7 @@ public Task<GetSystemInfoResponse> Handle(GetSystemInfoRequest request, Cancella
             }
 
             // TODO: is it possible to make that better?
-            systeminfoversions.Add(new SystemInfoVersionEntryDto("NETEVENT", Assembly.GetEntryAssembly().GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion));
+            systeminfoversions.Add(new SystemInfoVersionEntryDto("NETEVENT", Assembly.GetEntryAssembly()?.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion));
             systeminfoversions.Add(new SystemInfoVersionEntryDto("BUILDNODE", string.IsNullOrEmpty(Environment.GetEnvironmentVariable("BUILDNODE")) ? "dev" : Environment.GetEnvironmentVariable("BUILDNODE")));
             systeminfoversions.Add(new SystemInfoVersionEntryDto("BUILDID", string.IsNullOrEmpty(Environment.GetEnvironmentVariable("BUILDID")) ? "dev" : Environment.GetEnvironmentVariable("BUILDNODE")));
             systeminfoversions.Add(new SystemInfoVersionEntryDto("BUILDNUMBER", string.IsNullOrEmpty(Environment.GetEnvironmentVariable("BUILDNUMBER")) ? "dev" : Environment.GetEnvironmentVariable("BUILDNODE")));