🐛 Ranger Alertness doesn't appear to actually do anything

[cowlinator]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

Branch affected by issue

base

The problem

Ranger Alertness appears to have a modifier of 0 and a value of 0

server/sql/traits.sql

Line 234 in 76a5ba3

INSERT INTO `traits` VALUES (21,'alertness',11,5,1,0,0,NULL,0);

It also isn't used when enemies detect players

server/src/map/ai/controllers/mob_controller.cpp

Line 286 in 76a5ba3

auto CMobController::CanDetectTarget(CBattleEntity* PTarget, const bool forceSight) const -> bool

and it isn't actually used anywhere at all. It only exists in enums and data lists

https://github.com/search?q=repo%3ALandSandBoat%2Fserver%20alertness&type=code

Steps to reproduce

Be a ranger > level 5. Walk toward an enemy who detects by sight, and use a distance addon to see how far away they detect you.

Now do the same as a non-ranger.

It's the same.

Expected behavior

Ranger can get closer without being detected.

[almuth150]

More importantly, the Stealth trait from NIN appears to be affecting aggro range for all methods of detection. Although, a quick glance at BG wiki for both traits doesn't mention anything about detection range, so the existing implementation is also entirely incorrect.

[sruon]

Stealth is 100% made up. Both traits won't see traction until mobs get their proper aggro range accounting for time of day and weather.

Research and documentation would be welcome though!