Added check to see if the player has started the tutorial when speaki…#10535
Open
greentchristian-LSB wants to merge 1 commit into
Open
Added check to see if the player has started the tutorial when speaki…#10535greentchristian-LSB wants to merge 1 commit into
greentchristian-LSB wants to merge 1 commit into
Conversation
…ng with RoE NPCs. De;eted a line causing a duplicate message after CS.
claywar
reviewed
Jul 8, 2026
| entity.onTrigger = function(player, npc) | ||
| if player:getEminenceProgress(1) then | ||
| player:startEvent(24) | ||
| local tutorialStarted = player:getVar('HQuest[Tutorial]Prog') > 0 and 0 or 1 |
Contributor
There was a problem hiding this comment.
Really we shouldn't be handling this in the NPC scripts at all anymore. These are one-time events which complete the record, and should be moved to the Tutorial Hidden Quest
Contributor
Author
There was a problem hiding this comment.
Since it's not strictly part of the tutorial - rather, it's showing a different version of the CS if you haven't started the tutorial - moving the cutscene from all three RoE NPCs to wherever the script for the First Step Forward objective is might make more sense, but I'm not sure where the RoE scripts are kept.
Contributor
Author
There was a problem hiding this comment.
The biggest complication may just be that, this is the only RoE objective with an associated event, to the best of my knowledge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng with RoE NPCs. De;eted a line causing a duplicate message after CS.
I affirm:
What does this pull request do?
This is a very minor retail accuracy change. When a player starts Records of Eminence without first starting the tutorial, the game plays a slightly longer cutscene where the RoE NPC tells the player to go speak to the tutorial NPC. (In capture, it's the same event, with option 1.)
This adds a line to each of the RoE NPCs to determine if the player has started the tutorial, returning 0 if the player has started the tutorial and returning 1 if the player has not, then applies that variable as the first cutscene option, ensuring the player gets the retail correct version of the cutscene. Adjusts the onEventFinish check so that the function should trigger regardless of the version of the CS you get. Finally, also deletes a line from entity.onEventFinish that was causing a duplicate "You got beef jerky" message when finishing the CS.
Seriously, this message is longer than the change.
Steps to test these changes
Create a new character and start Records of Eminence without first starting the tutorial. You'll get a slightly longer cutscene telling you to start the tutorial. Create a character and start the tutorial before starting Records of Eminence. You'll get the shorter cutscene without the instruction.