Skip to content

[lua] Attachment Burden Penalties#10536

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Skold177:Attachment-Burdens
Jul 8, 2026
Merged

[lua] Attachment Burden Penalties#10536
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Skold177:Attachment-Burdens

Conversation

@Skold177

@Skold177 Skold177 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

In 2019, many attachments that used to consume maneuvers were converted to no longer consume maneuvers and instead place burden of that element on the master when used. This PR adds 7/14/21 burden to those attachments when used per maneuver active.

Did all the math in game, take a look at the capture if you're interested but all attachments showed the same burden values.

Oh and just incase anyone asks, I did test both Heat Capacitors together with 3 Fire Maneuvers, still the same burden applied.

Also includes some other bug fixes I found along the way for my PUP module, and also adds a override for Economizer I was missing.

Capture

https://www.youtube.com/watch?v=fLrHLIK3htQ
https://1drv.ms/u/c/a1ac08c33d8c8146/IQCpclSILVSaT7N6UGpNe2jLAf9GSaXoNzb1I6FgyY890TY?e=eHFPo7

Steps to test these changes

Use any of the changed attachments, feel burdened.

@Skold177 Skold177 force-pushed the Attachment-Burdens branch from a137930 to bc6ce9b Compare July 8, 2026 05:08
Comment thread scripts/actions/abilities/pets/attachments/flame_holder.lua Outdated
Comment thread scripts/actions/abilities/pets/attachments/ice_maker.lua Outdated
Adds Attachment Burden Values for Flame Holder, Ice Maker, Barrage Turbine, Economizer, Eraser, Heat Capacitor, and Replicator.
@Skold177 Skold177 force-pushed the Attachment-Burdens branch from bc6ce9b to 2f61c8f Compare July 8, 2026 14:31
@Xaver-DaRed Xaver-DaRed merged commit affbd99 into LandSandBoat:base Jul 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants