Skip to content

Add Acrolith mob skill list#10541

Closed
djjohnson13p wants to merge 1 commit into
LandSandBoat:basefrom
djjohnson13p:fix/issue-5494-acrolith-skill-list
Closed

Add Acrolith mob skill list#10541
djjohnson13p wants to merge 1 commit into
LandSandBoat:basefrom
djjohnson13p:fix/issue-5494-acrolith-skill-list

Conversation

@djjohnson13p

Copy link
Copy Markdown

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Part of #5494.

Adds the missing Acrolith mob skill list rows for skill_list_id 1. On current base, pool 39 (Acrolith) already points at skill_list_id 1, but mob_skill_lists.sql only had the -- 1: Acrolith section marker and no active rows for that list.

The new list uses the five active Acrolith skill definitions already present in mob_skills.sql and already used by the existing Wulgaru Acrolith list: dismemberment, dire_straight, earth_shatter, sinker_drill, and detonating_grip.

Evidence used:

  • Existing LSB data: Wulgaru list 302 already maps to skill IDs 2070-2074.
  • Public wiki evidence: BG Wiki and FFXIclopedia list the same Acrolith-family TP moves.
  • No proprietary client assets, DAT files, private captures, or leaked materials were used.

Steps to test these changes

Targeted static validation:

  • Confirmed pool 39 (Acrolith) uses skill_list_id 1.
  • Confirmed list 1 now contains skill IDs 2070-2074.
  • Confirmed all five skill IDs exist in mob_skills.sql.
  • Confirmed the 💭 Missing or incorrect skill lists #5494 missing-list condition no longer matches Acrolith.

Local checks run:

  • tools/ci/sanity_checks/sql.sh sql/mob_skill_lists.sql
  • tools/ci/sanity_checks/general.sh sql/mob_skill_lists.sql with PYTHONUTF8=1
  • tools/ci/sanity_checks/python.sh sql/mob_skill_lists.sql
  • tools/ci/sanity_checks/lua.sh sql/mob_skill_lists.sql with PYTHONUTF8=1
  • python tools/ci/sanity_checks/lua_stylecheck.py test
  • tools/ci/sanity_checks.sh upstream/base with PYTHONUTF8=1
  • git diff --check

Local limitations:

  • Docker compose/build/DB startup checks were not run locally. Docker Desktop and WSL2 are not installed/enabled on this Windows host, and enabling them would require OS feature changes and likely a reboot.

Fixes LandSandBoat#5494.

Pool 39 already points to skill_list_id 1, but list 1 only had an Acrolith section marker and no active rows. Add the five active Acrolith mob_skills that are already used by the existing Wulgaru list.
@djjohnson13p djjohnson13p marked this pull request as ready for review July 8, 2026 19:47
@sruon sruon closed this Jul 8, 2026
@djjohnson13p

Copy link
Copy Markdown
Author

Apologies for the noise here. This PR was opened by an AI-assisted workflow before it had the human review and fork-only staging that Dale intended. The work was meant to stay isolated in my fork/experimental branch until it could be reviewed properly, not to consume upstream maintainer time yet.

I'm withdrawing this PR now and will keep any further experimentation isolated to my fork unless I later prepare a manually reviewed contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants