Add Acrolith mob skill list#10541
Closed
djjohnson13p wants to merge 1 commit into
Closed
Conversation
Fixes LandSandBoat#5494. Pool 39 already points to skill_list_id 1, but list 1 only had an Acrolith section marker and no active rows. Add the five active Acrolith mob_skills that are already used by the existing Wulgaru list.
Author
|
Apologies for the noise here. This PR was opened by an AI-assisted workflow before it had the human review and fork-only staging that Dale intended. The work was meant to stay isolated in my fork/experimental branch until it could be reviewed properly, not to consume upstream maintainer time yet. I'm withdrawing this PR now and will keep any further experimentation isolated to my fork unless I later prepare a manually reviewed contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Part of #5494.
Adds the missing Acrolith mob skill list rows for
skill_list_id1. On currentbase, pool 39 (Acrolith) already points atskill_list_id1, butmob_skill_lists.sqlonly had the-- 1: Acrolithsection marker and no active rows for that list.The new list uses the five active Acrolith skill definitions already present in
mob_skills.sqland already used by the existing Wulgaru Acrolith list:dismemberment,dire_straight,earth_shatter,sinker_drill, anddetonating_grip.Evidence used:
Steps to test these changes
Targeted static validation:
Acrolith) usesskill_list_id1.mob_skills.sql.Local checks run:
tools/ci/sanity_checks/sql.sh sql/mob_skill_lists.sqltools/ci/sanity_checks/general.sh sql/mob_skill_lists.sqlwithPYTHONUTF8=1tools/ci/sanity_checks/python.sh sql/mob_skill_lists.sqltools/ci/sanity_checks/lua.sh sql/mob_skill_lists.sqlwithPYTHONUTF8=1python tools/ci/sanity_checks/lua_stylecheck.py testtools/ci/sanity_checks.sh upstream/basewithPYTHONUTF8=1git diff --checkLocal limitations: