Skip to content

Add Matamata mob skill list#10543

Closed
djjohnson13p wants to merge 1 commit into
LandSandBoat:basefrom
djjohnson13p:fix/issue-5494-matamata-skill-list
Closed

Add Matamata mob skill list#10543
djjohnson13p wants to merge 1 commit into
LandSandBoat:basefrom
djjohnson13p:fix/issue-5494-matamata-skill-list

Conversation

@djjohnson13p

@djjohnson13p djjohnson13p commented Jul 8, 2026

Copy link
Copy Markdown

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds missing mob_skill_lists rows for Matamata skill list 275, covering one focused slice of #5494.

Evidence used:

  • sql/mob_pools.sql assigns eight Matamata-family pools to skill list 275: Skittish_Matamata, Matamata, Emberflash_Matamata, Volatile_Matamata, Groundstomp_Matamata, Disturbed_Matamata, Sinewy_Matamata, and Apex_Matamata.
  • sql/mob_skill_lists.sql had only the placeholder comment for 275 and no active rows.
  • sql/mob_skills.sql already defines active Matamata skills 2965 through 2969: cranial_thrust, tail_thwack, embalming_earth, scalding_breath, and debilitating_spout.
  • Existing LSB skill list 348 already uses those same five Matamata skill IDs.
  • Public wiki family pages list the same Matamata-family TP moves.

This PR is not claiming packet-capture or retail-capture verification; it is a data-only correction based on current LSB data plus public wiki support. No proprietary client data, DAT files, packet captures, or private materials were used.

Steps to test these changes

Local checks run on Windows:

  • Targeted static parser check confirming list 275 contains 2965,2966,2967,2968,2969 and all five referenced skill IDs are active in mob_skills.sql.
  • PYTHONUTF8=1 bash tools/ci/sanity_checks/sql.sh sql/mob_skill_lists.sql
  • PYTHONUTF8=1 bash tools/ci/sanity_checks/general.sh sql/mob_skill_lists.sql
  • PYTHONUTF8=1 bash tools/ci/sanity_checks/python.sh sql/mob_skill_lists.sql
  • PYTHONUTF8=1 bash tools/ci/sanity_checks/lua.sh sql/mob_skill_lists.sql
  • PYTHONUTF8=1 python tools/ci/sanity_checks/lua_stylecheck.py test
  • git diff --check
  • Native MSVC/Ninja build using Visual Studio Build Tools 2022: passed after configuring build-msvc-cl with cl.exe.
  • Temporary MariaDB 12.3 database import via python tools/dbtool.py update full: passed.
  • DB query confirmed skill list 275 has the five intended skill rows and eight pools use list 275.
  • python tools/ci/startup_checks.py: passed; all server processes reached ready to work.

Local limitations:

  • PYTHONUTF8=1 bash tools/ci/sanity_checks.sh upstream/base was attempted, but timed out locally while running the Lua sanity phase. The targeted per-file sanity scripts listed above passed.
  • A direct xi_test.exe run was attempted separately, but it exited nonzero before producing a clean final summary in this Windows session; CI should provide the authoritative full test matrix.

Fixes one LandSandBoat#5494 missing skill-list slice by adding Matamata list 275 rows for the existing Matamata skill IDs 2965-2969.
@zach2good

Copy link
Copy Markdown
Contributor

"no packet capture data was used"

Why?

@djjohnson13p

Copy link
Copy Markdown
Author

Thanks, fair question. The wording was clumsy, so I updated the PR body.

I do not have a lawful retail packet capture for this slice, so I am not claiming packet-capture verification. The basis for the change is narrower: current LSB data already has eight Matamata-family pools pointing at list 275, active Matamata skills 2965-2969 in mob_skills.sql, an existing LSB skill list 348 using those same five skill IDs, and public wiki family pages listing the same TP moves. No proprietary client data, DAT files, packet captures, or private material were used.

@zach2good

Copy link
Copy Markdown
Contributor

Even the response seems like AI slop, closing

@zach2good zach2good closed this Jul 8, 2026
@LandSandBoat LandSandBoat locked as resolved and limited conversation to collaborators Jul 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants