Add Matamata mob skill list#10543
Closed
djjohnson13p wants to merge 1 commit into
Closed
Conversation
Fixes one LandSandBoat#5494 missing skill-list slice by adding Matamata list 275 rows for the existing Matamata skill IDs 2965-2969.
Contributor
|
"no packet capture data was used" Why? |
Author
|
Thanks, fair question. The wording was clumsy, so I updated the PR body. I do not have a lawful retail packet capture for this slice, so I am not claiming packet-capture verification. The basis for the change is narrower: current LSB data already has eight Matamata-family pools pointing at list 275, active Matamata skills 2965-2969 in |
Contributor
|
Even the response seems like AI slop, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Adds missing
mob_skill_listsrows for Matamata skill list275, covering one focused slice of #5494.Evidence used:
sql/mob_pools.sqlassigns eight Matamata-family pools to skill list275:Skittish_Matamata,Matamata,Emberflash_Matamata,Volatile_Matamata,Groundstomp_Matamata,Disturbed_Matamata,Sinewy_Matamata, andApex_Matamata.sql/mob_skill_lists.sqlhad only the placeholder comment for275and no active rows.sql/mob_skills.sqlalready defines active Matamata skills2965through2969:cranial_thrust,tail_thwack,embalming_earth,scalding_breath, anddebilitating_spout.348already uses those same five Matamata skill IDs.This PR is not claiming packet-capture or retail-capture verification; it is a data-only correction based on current LSB data plus public wiki support. No proprietary client data, DAT files, packet captures, or private materials were used.
Steps to test these changes
Local checks run on Windows:
275contains2965,2966,2967,2968,2969and all five referenced skill IDs are active inmob_skills.sql.PYTHONUTF8=1 bash tools/ci/sanity_checks/sql.sh sql/mob_skill_lists.sqlPYTHONUTF8=1 bash tools/ci/sanity_checks/general.sh sql/mob_skill_lists.sqlPYTHONUTF8=1 bash tools/ci/sanity_checks/python.sh sql/mob_skill_lists.sqlPYTHONUTF8=1 bash tools/ci/sanity_checks/lua.sh sql/mob_skill_lists.sqlPYTHONUTF8=1 python tools/ci/sanity_checks/lua_stylecheck.py testgit diff --checkbuild-msvc-clwithcl.exe.python tools/dbtool.py update full: passed.275has the five intended skill rows and eight pools use list275.python tools/ci/startup_checks.py: passed; all server processes reachedready to work.Local limitations:
PYTHONUTF8=1 bash tools/ci/sanity_checks.sh upstream/basewas attempted, but timed out locally while running the Lua sanity phase. The targeted per-file sanity scripts listed above passed.xi_test.exerun was attempted separately, but it exited nonzero before producing a clean final summary in this Windows session; CI should provide the authoritative full test matrix.