Skip to content

Commit 2f839ee

Browse files
committed
Disable a failed PPL query fallback to v2 by default
Signed-off-by: Lantao Jin <ltjin@amazon.com>
1 parent 739c4df commit 2f839ee

13 files changed

Lines changed: 9 additions & 31 deletions

File tree

docs/user/admin/settings.rst

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -749,9 +749,9 @@ plugins.calcite.enabled
749749
Description
750750
-----------
751751

752-
This setting is present from 3.0.0-beta. You can enable Calcite as new query optimizer and execution engine to all coming requests.
752+
You can enable Calcite as new query optimizer and execution engine to all coming requests.
753753

754-
1. The default value is false in 3.0.0-beta.
754+
1. The default value is false since 3.0.0.
755755
2. This setting is node scope.
756756
3. This setting can be updated dynamically.
757757

@@ -764,9 +764,9 @@ plugins.calcite.fallback.allowed
764764
Description
765765
-----------
766766

767-
This setting is present from 3.0.0-beta. If Calcite is enabled, you can use this setting to decide whether to allow fallback to v2 engine for some queries which are not supported by v3 engine.
767+
If Calcite is enabled, you can use this setting to decide whether to allow fallback to v2 engine for some queries which are not supported by v3 engine.
768768

769-
1. The default value is true in 3.0.0-beta.
769+
1. The default value is false since 3.2.0.
770770
2. This setting is node scope.
771771
3. This setting can be updated dynamically.
772772

@@ -776,9 +776,9 @@ plugins.calcite.pushdown.enabled
776776
Description
777777
-----------
778778

779-
This setting is present from 3.0.0-beta. If Calcite is enabled, you can use this setting to decide whether to enable the operator pushdown optimization for v3 engine.
779+
If Calcite is enabled, you can use this setting to decide whether to enable the operator pushdown optimization for v3 engine.
780780

781-
1. The default value is true in 3.0.0-beta.
781+
1. The default value is true since 3.0.0.
782782
2. This setting is node scope.
783783
3. This setting can be updated dynamically.
784784

@@ -788,8 +788,8 @@ plugins.calcite.pushdown.rowcount.estimation.factor
788788
Description
789789
-----------
790790

791-
This setting is present from 3.1.0. If Calcite pushdown optimization is enabled, this setting is used to estimate the row count of the query plan. The value is a factor to multiply the row count of the table scan to get the estimated row count.
791+
If Calcite pushdown optimization is enabled, this setting is used to estimate the row count of the query plan. The value is a factor to multiply the row count of the table scan to get the estimated row count.
792792

793-
1. The default value is 0.9 in 3.1.0.
793+
1. The default value is 0.9 since 3.1.0.
794794
2. This setting is node scope.
795795
3. This setting can be updated dynamically.

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/2489.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ setup:
1515
body:
1616
transient:
1717
plugins.calcite.enabled : true
18-
plugins.calcite.fallback.allowed : false
1918

2019
---
2120
teardown:
@@ -24,7 +23,6 @@ teardown:
2423
body:
2524
transient:
2625
plugins.calcite.enabled : false
27-
plugins.calcite.fallback.allowed : true
2826

2927
---
3028
"Handle epoch field in string format":

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/3343.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ setup:
1616
body:
1717
transient:
1818
plugins.calcite.enabled : true
19-
plugins.calcite.fallback.allowed : false
2019

2120
---
2221
teardown:
@@ -25,7 +24,6 @@ teardown:
2524
body:
2625
transient:
2726
plugins.calcite.enabled : false
28-
plugins.calcite.fallback.allowed : true
2927

3028
---
3129
"Handle struct field with dynamic mapping disabled":

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/3477.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ setup:
44
body:
55
transient:
66
plugins.calcite.enabled : true
7-
plugins.calcite.fallback.allowed : false
87

98
---
109
teardown:
@@ -13,7 +12,6 @@ teardown:
1312
body:
1413
transient:
1514
plugins.calcite.enabled : false
16-
plugins.calcite.fallback.allowed : true
1715

1816
---
1917
"Handle flattened document value":

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/3570.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ setup:
44
body:
55
transient:
66
plugins.calcite.enabled: true
7-
plugins.calcite.fallback.allowed: false
87
- do:
98
bulk:
109
index: hdfs_logs
@@ -35,7 +34,6 @@ teardown:
3534
body:
3635
transient:
3736
plugins.calcite.enabled : false
38-
plugins.calcite.fallback.allowed : true
3937

4038

4139
---

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/3595.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ setup:
44
body:
55
transient:
66
plugins.calcite.enabled : true
7-
plugins.calcite.fallback.allowed : false
87
plugins.query.size_limit : 1
98

109
---
@@ -14,7 +13,6 @@ teardown:
1413
body:
1514
transient:
1615
plugins.calcite.enabled : false
17-
plugins.calcite.fallback.allowed : true
1816

1917
---
2018
"Handle lookup command with query size limit is 1":

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/3607.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ setup:
1010
body:
1111
transient:
1212
plugins.calcite.enabled : true
13-
plugins.calcite.fallback.allowed : false
1413
plugins.query.size_limit : 200
1514

1615
---
@@ -20,7 +19,6 @@ teardown:
2019
body:
2120
transient:
2221
plugins.calcite.enabled : false
23-
plugins.calcite.fallback.allowed : true
2422

2523
---
2624
"Handle aggregation with window_size_limit is less than query.size_limit":

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/3635.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ setup:
44
body:
55
transient:
66
plugins.calcite.enabled : true
7-
plugins.calcite.fallback.allowed : false
87

98
---
109
teardown:
@@ -13,7 +12,6 @@ teardown:
1312
body:
1413
transient:
1514
plugins.calcite.enabled : false
16-
plugins.calcite.fallback.allowed : true
1715

1816
---
1917
"Push down filter with nested field":

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/3646.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ setup:
3232
body:
3333
transient:
3434
plugins.calcite.enabled : true
35-
plugins.calcite.fallback.allowed : false
3635

3736
---
3837
teardown:
@@ -41,7 +40,6 @@ teardown:
4140
body:
4241
transient:
4342
plugins.calcite.enabled : false
44-
plugins.calcite.fallback.allowed : true
4543

4644
---
4745
"Path of alias type points to nested field":

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/3655.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ teardown:
3434
body:
3535
transient:
3636
plugins.calcite.enabled : false
37-
plugins.calcite.fallback.allowed : true
3837

3938
---
4039
"Support match_only_text field type with Calcite enabled":
@@ -43,7 +42,6 @@ teardown:
4342
body:
4443
transient:
4544
plugins.calcite.enabled : true
46-
plugins.calcite.fallback.allowed : false
4745

4846
- do:
4947
headers:

0 commit comments

Comments
 (0)