Skip to content

Commit cc8941c

Browse files
committed
Address the comments of 3929 followup
Signed-off-by: Lantao Jin <ltjin@amazon.com>
1 parent d3f9c8f commit cc8941c

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

core/src/main/java/org/opensearch/sql/calcite/CalcitePlanContext.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ public class CalcitePlanContext {
3636
public final QueryType queryType;
3737
public final Integer querySizeLimit;
3838

39+
/** This thread local variable is only used to skip script encoding in script pushdown. */
3940
public static final ThreadLocal<Boolean> skipEncoding = ThreadLocal.withInitial(() -> false);
4041

4142
@Getter @Setter private boolean isResolvingJoinCondition = false;

integ-test/src/test/java/org/opensearch/sql/ppl/PPLIntegTestCase.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import static org.opensearch.sql.legacy.TestUtils.getResponseBody;
99
import static org.opensearch.sql.plugin.rest.RestPPLQueryAction.EXPLAIN_API_ENDPOINT;
10-
import static org.opensearch.sql.plugin.rest.RestPPLQueryAction.EXTENDED_EXPLAIN_API_ENDPOINT;
1110
import static org.opensearch.sql.plugin.rest.RestPPLQueryAction.QUERY_API_ENDPOINT;
1211

1312
import com.google.common.io.Resources;
@@ -32,6 +31,8 @@
3231

3332
/** OpenSearch Rest integration test base for PPL testing. */
3433
public abstract class PPLIntegTestCase extends SQLIntegTestCase {
34+
private static final String EXTENDED_EXPLAIN_API_ENDPOINT =
35+
"/_plugins/_ppl/_explain?format=extended";
3536
private static final Logger LOG = LogManager.getLogger();
3637

3738
@Override

plugin/src/main/java/org/opensearch/sql/plugin/rest/RestPPLQueryAction.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@
4141
public class RestPPLQueryAction extends BaseRestHandler {
4242
public static final String QUERY_API_ENDPOINT = "/_plugins/_ppl";
4343
public static final String EXPLAIN_API_ENDPOINT = "/_plugins/_ppl/_explain";
44-
public static final String EXTENDED_EXPLAIN_API_ENDPOINT =
45-
"/_plugins/_ppl/_explain?format=extended";
4644

4745
private static final Logger LOG = LogManager.getLogger();
4846

0 commit comments

Comments
 (0)