Fix flaky string format in test

Signed-off-by: Lantao Jin <ltjin@amazon.com>

Author: LantaoJin

async-query-core/src/main/java/org/opensearch/sql/spark/asyncquery/AsyncQueryExecutorServiceImpl.java

@@ -11,6 +11,7 @@
 import com.amazonaws.services.emrserverless.model.JobRunState;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Locale;
 import java.util.Optional;
 import lombok.AllArgsConstructor;
 import org.json.JSONObject;
@@ -109,7 +110,8 @@ public AsyncQueryExecutionResponse getAsyncQueryResults(
             sessionId);
       }
     }
-    throw new AsyncQueryNotFoundException(String.format("QueryId: %s not found", queryId));
+    throw new AsyncQueryNotFoundException(
+        String.format(Locale.ROOT, "QueryId: %s not found", queryId));
   }
 
   @Override
@@ -123,6 +125,7 @@ public String cancelQuery(String queryId, AsyncQueryRequestContext asyncQueryReq
           asyncQueryJobMetadata.get(), QueryState.CANCELLED, asyncQueryRequestContext);
       return result;
     }
-    throw new AsyncQueryNotFoundException(String.format("QueryId: %s not found", queryId));
+    throw new AsyncQueryNotFoundException(
+        String.format(Locale.ROOT, "QueryId: %s not found", queryId));
   }
 }

async-query-core/src/main/java/org/opensearch/sql/spark/client/EMRServerlessClientFactoryImpl.java

@@ -12,6 +12,7 @@
 import com.amazonaws.services.emrserverless.AWSEMRServerlessClientBuilder;
 import java.security.AccessController;
 import java.security.PrivilegedAction;
+import java.util.Locale;
 import lombok.RequiredArgsConstructor;
 import org.opensearch.sql.spark.asyncquery.model.NullAsyncQueryRequestContext;
 import org.opensearch.sql.spark.config.SparkExecutionEngineConfig;
@@ -48,6 +49,7 @@ private void validateSparkExecutionEngineConfig(
     if (sparkExecutionEngineConfig == null || sparkExecutionEngineConfig.getRegion() == null) {
       throw new IllegalArgumentException(
           String.format(
+              Locale.ROOT,
               "Async Query APIs are disabled. Please configure %s in cluster settings to enable"
                   + " them.",
               SPARK_EXECUTION_ENGINE_CONFIG.getKeyValue()));

async-query-core/src/main/java/org/opensearch/sql/spark/client/EmrServerlessClientImpl.java

@@ -23,6 +23,7 @@
 import com.amazonaws.services.emrserverless.model.ValidationException;
 import java.security.AccessController;
 import java.security.PrivilegedAction;
+import java.util.Locale;
 import lombok.RequiredArgsConstructor;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.logging.log4j.LogManager;
@@ -128,7 +129,7 @@ public CancelJobRunResult cancelJobRun(
                     throw new RuntimeException(GENERIC_INTERNAL_SERVER_ERROR_MESSAGE);
                   }
                 });
-    logger.info(String.format("Job : %s cancelled", cancelJobRunResult.getJobRunId()));
+    logger.info(String.format(Locale.ROOT, "Job : %s cancelled", cancelJobRunResult.getJobRunId()));
     return cancelJobRunResult;
   }
 }

async-query-core/src/main/java/org/opensearch/sql/spark/dispatcher/IndexDMLHandler.java

@@ -9,6 +9,7 @@
 import static org.opensearch.sql.spark.data.constants.SparkConstants.STATUS_FIELD;
 
 import com.amazonaws.services.emrserverless.model.JobRunState;
+import java.util.Locale;
 import java.util.Map;
 import lombok.RequiredArgsConstructor;
 import org.apache.commons.lang3.StringUtils;
@@ -145,6 +146,7 @@ private FlintIndexOp getIndexOp(
       default:
         throw new IllegalStateException(
             String.format(
+                Locale.ROOT,
                 "IndexQueryActionType: %s is not supported in IndexDMLHandler.",
                 indexQueryDetails.getIndexQueryActionType()));
     }
@@ -158,7 +160,9 @@ private FlintIndexMetadata getFlintIndexMetadata(
     if (!indexMetadataMap.containsKey(indexDetails.openSearchIndexName())) {
       throw new IllegalStateException(
           String.format(
-              "Couldn't fetch flint index: %s details", indexDetails.openSearchIndexName()));
+              Locale.ROOT,
+              "Couldn't fetch flint index: %s details",
+              indexDetails.openSearchIndexName()));
     }
     return indexMetadataMap.get(indexDetails.openSearchIndexName());
   }

async-query-core/src/main/java/org/opensearch/sql/spark/dispatcher/RefreshQueryHandler.java

@@ -5,6 +5,7 @@
 
 package org.opensearch.sql.spark.dispatcher;
 
+import java.util.Locale;
 import java.util.Map;
 import org.opensearch.sql.datasource.model.DataSourceMetadata;
 import org.opensearch.sql.spark.asyncquery.model.AsyncQueryJobMetadata;
@@ -63,7 +64,9 @@ public String cancelJob(
     if (!indexMetadataMap.containsKey(asyncQueryJobMetadata.getIndexName())) {
       throw new IllegalStateException(
           String.format(
-              "Couldn't fetch flint index: %s details", asyncQueryJobMetadata.getIndexName()));
+              Locale.ROOT,
+              "Couldn't fetch flint index: %s details",
+              asyncQueryJobMetadata.getIndexName()));
     }
     FlintIndexMetadata indexMetadata = indexMetadataMap.get(asyncQueryJobMetadata.getIndexName());
     FlintIndexOp jobCancelOp = flintIndexOpFactory.getCancel(datasourceName);

async-query-core/src/main/java/org/opensearch/sql/spark/dispatcher/model/IndexQueryDetails.java

@@ -7,6 +7,7 @@
 
 import static org.apache.commons.lang3.StringUtils.strip;
 
+import java.util.Locale;
 import java.util.Set;
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
@@ -134,7 +135,7 @@ private String percentEncode(String indexName) {
     StringBuilder builder = new StringBuilder(indexName.length());
     for (char ch : indexName.toCharArray()) {
       if (INVALID_INDEX_NAME_CHARS.contains(ch)) {
-        builder.append(String.format("%%%02X", (int) ch));
+        builder.append(String.format(Locale.ROOT, "%%%02X", (int) ch));
       } else {
         builder.append(ch);
       }

async-query-core/src/main/java/org/opensearch/sql/spark/execution/session/InteractiveSession.java

@@ -11,6 +11,7 @@
 import static org.opensearch.sql.spark.execution.session.SessionState.FAIL;
 import static org.opensearch.sql.spark.execution.statement.StatementId.newStatementId;
 
+import java.util.Locale;
 import java.util.Optional;
 import lombok.Builder;
 import lombok.Getter;
@@ -111,6 +112,7 @@ public StatementId submit(
       } else {
         String errMsg =
             String.format(
+                Locale.ROOT,
                 "can't submit statement, session should not be in end state, "
                     + "current session state is: %s",
                 sessionModel.getSessionState().getSessionState());

async-query-core/src/main/java/org/opensearch/sql/spark/execution/statement/Statement.java

@@ -7,6 +7,7 @@
 
 import static org.opensearch.sql.spark.execution.statement.StatementModel.submitStatement;
 
+import java.util.Locale;
 import lombok.Builder;
 import lombok.Getter;
 import lombok.Setter;
@@ -64,8 +65,10 @@ public void cancel() {
         || statementState.equals(StatementState.CANCELLED)) {
       String errorMsg =
           String.format(
+              Locale.ROOT,
               "can't cancel statement in %s state. statement: %s.",
-              statementState.getState(), statementId);
+              statementState.getState(),
+              statementId);
       LOG.error(errorMsg);
       throw new IllegalStateException(errorMsg);
     }

async-query-core/src/main/java/org/opensearch/sql/spark/execution/statestore/OpenSearchStateStoreUtil.java

@@ -15,6 +15,9 @@ public class OpenSearchStateStoreUtil {
 
   public static String getIndexName(String datasourceName) {
     return String.format(
-        "%s_%s", SPARK_REQUEST_BUFFER_INDEX_NAME, datasourceName.toLowerCase(Locale.ROOT));
+        Locale.ROOT,
+        "%s_%s",
+        SPARK_REQUEST_BUFFER_INDEX_NAME,
+        datasourceName.toLowerCase(Locale.ROOT));
   }
 }

async-query-core/src/main/java/org/opensearch/sql/spark/execution/statestore/StateModel.java

@@ -6,6 +6,7 @@
 package org.opensearch.sql.spark.execution.statestore;
 
 import com.google.common.collect.ImmutableMap;
+import java.util.Locale;
 import java.util.Optional;
 import lombok.Builder.Default;
 import lombok.EqualsAndHashCode;
@@ -27,8 +28,11 @@ public <T> Optional<T> getMetadataItem(String name, Class<T> type) {
       } else {
         throw new RuntimeException(
             String.format(
+                Locale.ROOT,
                 "The metadata field %s is an instance of %s instead of %s",
-                name, value.getClass(), type));
+                name,
+                value.getClass(),
+                type));
       }
     } else {
       return Optional.empty();