Refactor to PHP 8.1#5060
Conversation
[ci skip] [skip ci]
[ci skip] [skip ci]
|
Is this ready for me to review? No breaking changes? |
|
This has no BCs that I am aware of (at least it shouldn't). I would probably just be cautious on the Apart from that it seems that's just adding a bunch of arrow functions and removing parameters from doc block. Can it break ? There is the possibility, it's not 0! If we say in doc block I caught some of those as you can see in my commits after the big rector one. |
|
Ok got it. I've tagged this as a SHOULD and will take a look as soon as we're done with all MUSTs. |
This is a Rector run with PHP 8.1 as the target version, and some more changes I did myself that rector didn't get.
(Rector does not automatically delete notated parameters in docblock if they have adicional comments, so there is still ALOT of them!)
Some changes are preferences that we can configure if required.