[WIP] dont load locally when in dev mode#5511
Open
pxpm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
When basset is in Dev mode, calling
Basset::basset($asset)marks it as loaded even if not internalized.We have two options here:
This PR works as expected and is the easiest (from the side effects perspective), but removing
LOADEDfrom the status array is the cleanest, so I opened this PR in the hopes that we can remove the LOADED, but I am not sure about all the implications, nor why LOADED was added there.Maybe for the use case when you have multiple
backpack_avatar_url()calls ?Clarify my doubts here @promatik 🙏