Implement setting column resolution - #161
Open
pxpm wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datetime column was ignoring the format option because the list view was rendering setting values as plain text, regardless of the field type. This PR makes the value column actually respect the field definition.
What changed:
FieldToColumnResolverthat translates a field definition into a column definition. Blacklists form-only keys (validation, attributes, view_namespace, ...) and lets everything else through, so new column types in future Backpack releases work without changes here.UploaderColumnHydratorso withFiles / withMedia columns resolve stored paths to URLs per-row (can't use the macro's global retrieved event here — every Setting row shares the same model + value attribute, last uploader would win).BC:
Off by default. Set
auto_resolve_columns => truein the published config to opt in. Existing installs see no change until they publish the new migration and flip the flag. Planning to default it to true in the next major.Tests: 31 new tests covering the resolver and the hydrator.