Translated into Vietnamese#585
Conversation
|
BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly. Please keep in mind that:
Thank you! -- |
|
Hey @TanNhatCMS Thanks for submitting Vietnamese translations. @pxpm I have a doubt... He just submitted a Vietnamese translation to base packages, so I find it weird to publish them in the demo again. I think translations are supposed to be automatically picked from base. |
|
@karandatwani92 indeed, some are required to be overwritten so that we say stuff like: But I agree with you, there are some strings that I don't think they need translation here in demo. Can you do a review of https://github.com/Laravel-Backpack/demo/blob/main/lang/vendor/backpack/en/crud.php and cross check with the package strings, the ones we don't need to be overwriting in the demo ? We can first delete them from the Cheers |
Translated into Vietnamese by TanNhatCMS