feat(queue): native cross-source play queue#337
Merged
Conversation
… and resume Play queued Spotify tracks through the native streaming player and resume the underlying context when the queue drains. - try_play_queued Spotify arm: require a connected streaming player, silence any decoded audio, then play_uri the track and publish a Spotify queue slot. - Suspend the native-Spotify context on end-of-track and manual skip, preempting Spirc self-advance with a pause() before handing the sink to the queue. - ResumeSpotifyContext network handler re-loads the context (offset by the resume track) via the existing start_playback machinery. - Spirc self-advance guard reissues the queued track if librespot switches away, bounded by a retry budget.
…ive queue Add a dimmed, non-selectable 'Up next from context' preview to the Queue screen showing what resumes once the native queue drains: the tail of the suspended (or still-playing) per-source context, or the Spotify Web-API mirror for a native-Spotify context, or the station name for radio. Selection stays confined to the native-queue rows. Render the Queue title hint with the configured remove_from_queue key, add the missing Enter/jump help entry, document the queue in README and CHANGELOG (issue #206), and suppress the empty-queue hint while the queue owns playback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a native play queue that works across every source (Spotify, Local Files, Subsonic, YouTube) in one FIFO, plus the reliability and responsiveness work that came out of live-testing the Spotify-to-YouTube handoff.
Feature
zon any track to queue it natively; queued tracks play before the underlying playlist/album context, then the context resumes where it left off.Shift+Q): remove (x, rebindable), reorder (J/K), jump ahead (Enter), plus an up-next preview of what resumes after the queue drains.zkeeps the Web API queue behavior.last_session.yml).Handoff reliability and responsiveness
try_lock, so the queue handoff can never be silently dropped by a lock race with the render loop.Notable non-obvious finding: Spirc ignores player events from direct
player.loadcalls (play_request_id mismatch), so it never self-advances off a queued track; the ghost-audio bugs were all missing pause/release calls in the queue engine.Testing
cargo clippy -D warningsclean on slim (--no-default-features --features telemetry), default, and--features all-sources.cargo test: 349 passing on slim, 568 with all sources, including regression tests for slot clearing and queue routing.Closes #206