Skip to content

Commit e8321d2

Browse files
authored
[None][chore] Remove unused token_range and is_last_slice parameters from _create_kv_slice (NVIDIA#16083)
Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
1 parent 1225445 commit e8321d2

2 files changed

Lines changed: 4 additions & 19 deletions

File tree

tensorrt_llm/_torch/disaggregation/transceiver.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -167,12 +167,7 @@ def __enter__(self):
167167
def __exit__(self, _exc_type, _exc_val, _exc_tb):
168168
self.shutdown()
169169

170-
def _create_kv_slice(
171-
self,
172-
req: LlmRequest,
173-
token_range: Optional[TokenRange] = None,
174-
is_last_slice: bool = True,
175-
) -> KVSlice:
170+
def _create_kv_slice(self, req: LlmRequest) -> KVSlice:
176171
adapter = self._reuse_adapter
177172
tpb = adapter.tokens_per_block
178173
assert self._page_table is not None
@@ -185,7 +180,8 @@ def _create_kv_slice(
185180
else [0] * len(layer_groups)
186181
)
187182

188-
if token_range is None and req.prompt_len > 0:
183+
token_range = None
184+
if req.prompt_len > 0:
189185
# Align with KV cache allocation (prepare_disagg_gen_init /
190186
# _get_context_bytes), which reserves prompt_len +
191187
# num_extra_kv_tokens slots for speculative decoding methods
@@ -236,7 +232,7 @@ def _create_kv_slice(
236232
mamba_state_index = self._kv_cache_manager.mamba_cache_index[req.py_request_id]
237233

238234
return KVSlice(
239-
is_last_slice=is_last_slice,
235+
is_last_slice=True,
240236
block_ids_per_layer_groups=groups,
241237
mamba_state_index=mamba_state_index,
242238
token_range=token_range,

tests/unittest/disaggregated/test_cache_reuse_adapter.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -342,17 +342,6 @@ def test_defaults_to_prompt_len_when_no_extra(self):
342342
assert kv_slice.token_range is not None
343343
assert (kv_slice.token_range.start, kv_slice.token_range.end) == (0, prompt_len)
344344

345-
def test_respects_explicit_token_range(self):
346-
prompt_len = 17
347-
transceiver, req = _build_transceiver_for_kv_slice(
348-
num_extra_kv_tokens=7, prompt_len=prompt_len
349-
)
350-
explicit = TokenRange(start=0, end=8)
351-
352-
kv_slice = transceiver._create_kv_slice(req, token_range=explicit)
353-
354-
assert kv_slice.token_range is explicit
355-
356345

357346
# ---------------------------------------------------------------------------
358347
# CacheReuseAdapter.get_cached_token_count_per_layer_group: SWA clamp.

0 commit comments

Comments
 (0)