Merge pull request #214 from Latitudes-Dev/shuvcode-dev

Merge shuvcode-dev: Issues 210, 211, 212, 213 + upstream sync v1.0.207

Author: shuv1337

.github/last-synced-tag

@@ -1 +1 @@
-v1.0.204
+v1.0.207

CONTEXT/PLAN-210-211-212-open-issues-2025-12-28.md

@@ -0,0 +1,172 @@
+# Project Plan: Resolve Open Issues 210, 211, 212 (2025-12-28)
+
+## Scope Overview
+This plan addresses three open issues in Latitudes-Dev/shuvcode:
+- #210: Local dev mode skips installing .opencode tool dependencies
+- #211: Add directory picker + name field to Create New project flow
+- #212: Archived sessions reappear due to client-side filtering gaps and unused pipe() result
+
+## Context & Decisions Captured
+### Issue 210: .opencode tool dependencies not installed in local dev
+- Root cause: `installDependencies()` in `packages/opencode/src/config/config.ts` returns early when `Installation.isLocal()` is true, so `@opencode-ai/plugin` is not installed for `.opencode/tool` in `bun dev`.
+- Production builds do install dependencies; local dev skips them, causing import errors in tool registry loading.
+- Acceptance criteria from issue:
+  - Custom tools in `.opencode/tool/` load without errors when running `bun dev`.
+  - Fix must not break production builds.
+  - Dependencies should install for local dev without conflicting with global config.
+  - Backward compatible with existing `.opencode` configs.
+- Options explicitly discussed in issue:
+  - A) Remove local early return (simple; may cause repeated installs).
+  - B) Add docs/setup script (manual, not automatic).
+  - C) Bundle dependencies during local dev (extend plugin bundling pattern).
+  - D) Install on first tool load failure and retry.
+- Decision: Align with upstream by implementing Option A (remove local early return) with a per-directory, concurrency-safe guard to avoid repeated installs while keeping behavior consistent.
+- Guard definition (required):
+  - Use a deterministic marker file in each config dir (e.g., `.opencode/.deps-installed.json`) storing the installed version and timestamp.
+  - Skip install when marker matches the expected version (`Installation.BASE_VERSION` for non-local, `latest` for local).
+  - Serialize installs per directory to avoid concurrent `bun add` calls.
+
+### Issue 211: Add directory picker + name field to Create New flow
+- Current UI in `packages/app/src/components/dialog-create-project.tsx` has two tabs: Add Existing and Create New. Create New uses a single absolute path field and optional repo URL.
+- Desired behavior:
+  - Three distinct flows: Add Existing, Create New, Git Clone.
+  - Create New: pick parent directory + enter project name; show resolved path with validation; creates new folder.
+  - Git Clone: repo URL + target folder picker; derive folder name from repo if blank; optional degit.
+  - Add Existing stays unchanged.
+- API integration: `project.create` endpoint in `packages/opencode/src/server/project.ts` and `packages/opencode/src/project/project.ts` accepts `path`, optional `repo`, optional `degit`, optional `name`.
+- Critical semantic clarification:
+  - The server does NOT build the directory path from `name`; it only uses `path` to create folders.
+  - The client must construct the absolute `path` (parent + folder name) before calling `project.create`.
+  - The `name` field is metadata only (display name) and must not be relied on for path composition.
+- Platform constraints:
+  - `openDirectoryPickerDialog` is Tauri-only; web must use manual path input.
+  - The UI must gate picker usage on availability and keep a text input fallback.
+
+### Issue 212: Archived sessions reappear
+- Root causes:
+  - Client-side: `packages/app/src/context/sync.tsx` lacks archived filtering during initial session load and pagination fetch.
+  - Server-side: `packages/opencode/src/server/server.ts` calls `pipe(...)` but discards its result, returning unfiltered sessions.
+- Upstream works due to `global-sync.tsx` filtering; fork uses `sync.tsx` without filtering.
+- Acceptance criteria:
+  - Filter archived sessions in `sync.tsx` initial load and fetch.
+  - Fix server endpoint to return filtered sessions.
+  - Avoid duplicated listing and preserve intended sort order.
+
+## Code References (Internal)
+- Issue 210:
+  - `packages/opencode/src/config/config.ts`
+  - `packages/opencode/src/tool/registry.ts`
+  - `packages/opencode/src/plugin/index.ts`
+  - `packages/opencode/src/installation/index.ts`
+- Issue 211:
+  - `packages/app/src/components/dialog-create-project.tsx`
+  - `packages/opencode/src/server/project.ts`
+  - `packages/opencode/src/project/project.ts`
+  - `packages/app/src/context/platform.tsx` (for `openDirectoryPickerDialog` usage)
+- Issue 212:
+  - `packages/app/src/context/sync.tsx`
+  - `packages/opencode/src/server/server.ts`
+  - `packages/app/src/context/global-sync.tsx` (existing filtering behavior)
+
+## External References (Git URLs)
+- Directory picker usage example (React/Web File System Access API):
+  - https://github.com/dinoosauro/easy-backup/blob/a20006f442103b52521419255fe20331760b6d2e/src/App.tsx
+- Cross-runtime directory picker abstraction:
+  - https://github.com/ayonli/jsext/blob/ccf374f99a190ad497b5cec974ea20badbe1c8de/dialog/file.ts
+
+## Technical Specifications
+### API Endpoints
+- `GET /project/browse` (browse directories)
+- `POST /project` (`project.create`)
+- `GET /session` (`session.list`)
+
+### Data Models
+- `Project.Create` request fields (from `Project.create.schema`):
+  - `path: string` (absolute, required, client-composed from parent + folder name)
+  - `name?: string` (display name only)
+  - `repo?: string`
+  - `degit?: boolean`
+- `Project.CreateResult`:
+  - `project: Project.Info`
+  - `created: boolean`
+- `Session.Info` includes `time.archived?: number` (used for filtering)
+
+### Configuration & Flags
+| Item | Location | Purpose | Notes |
+| --- | --- | --- | --- |
+| `Installation.isLocal()` | `packages/opencode/src/installation/index.ts` | Detect local dev channel | `OPENCODE_CHANNEL === "local"` |
+| `installDependencies()` | `packages/opencode/src/config/config.ts` | Adds `@opencode-ai/plugin` | Needs per-dir guard and concurrency control |
+
+## Milestones & Implementation Order
+### Milestone 1: Fix archived session filtering (Issue 212)
+- Rationale: Small, isolated change with clear acceptance criteria; reduces user-facing bug quickly.
+
+### Milestone 2: Update Add Project modal flows (Issue 211)
+- Rationale: Larger UI change with dependencies on picker behavior and validation; benefits from stable session list behavior.
+
+### Milestone 3: Fix local tool dependency install (Issue 210)
+- Rationale: Dev workflow improvement; can be implemented after UI work without impacting feature logic.
+
+## Detailed Task Breakdown
+### Issue 212: Archived sessions filtering
+- [x] Add `.filter((s) => !s.time.archived)` to initial session load in `packages/app/src/context/sync.tsx`.
+- [x] Add `.filter((s) => !s.time.archived)` to `fetch` in `packages/app/src/context/sync.tsx`.
+- [x] Fix server-side filtering to return filtered sessions by assigning `pipe(...)` result to `sessions` in `packages/opencode/src/server/server.ts`.
+- [x] Remove duplicate `Session.list()` call and preserve intended sort order (use the filtered list).
+- [x] Add/adjust tests in `packages/opencode/test/` to ensure archived sessions are excluded from list responses.
+- [x] Validate UI list no longer shows archived sessions when reloading or paginating.
+
+### Issue 211: Add Project modal flows
+- [x] Expand tab model to three states: `existing`, `create`, `clone` in `packages/app/src/components/dialog-create-project.tsx`.
+- [x] Extract shared path preview/validation helper for Create New + Git Clone where feasible.
+- [x] Create New flow:
+  - [x] Add parent directory picker using `platform.openDirectoryPickerDialog` when available; otherwise use text input.
+  - [x] Add required project name input.
+  - [x] Compute and display resolved path (`parentDir + projectName`) on the client.
+  - [x] Validate name/path (non-empty; no path separators; no traversal; resolved path absolute) and show inline errors.
+- [x] Git Clone flow:
+  - [x] Add repo URL input.
+  - [x] Add parent directory picker with fallback text input.
+  - [x] Add optional project name; derive from repo URL when empty (no path separators).
+  - [x] Add optional degit toggle.
+  - [x] Show resolved target path before submission.
+- [x] Wire Create New and Git Clone to `globalSDK.client.project.create({ path, repo?, degit?, name? })`.
+  - `path` must be fully composed on the client; `name` is display-only metadata.
+- [x] Ensure Add Existing flow behavior remains unchanged.
+- [x] Add/adjust tests in `packages/opencode/test/` covering `project.create` path composition and validation for create/clone scenarios.
+- [x] Smoke test all three flows: Add Existing, Create New, Git Clone.
+
+### Issue 210: Local dev tool dependency install
+- [x] Modify `installDependencies()` in `packages/opencode/src/config/config.ts` to allow local install with a per-directory guard (align with upstream behavior).
+- [x] Implement a deterministic marker file (e.g., `.opencode/.deps-installed.json`) storing installed version and timestamp; skip when valid.
+- [x] Serialize installs per directory to avoid concurrent `bun add` when multiple config directories load in parallel.
+- [x] Ensure `.opencode/tool` installs do not affect global config.
+- [x] Add/adjust tests in `packages/opencode/test/` to verify tool loading works in local dev mode without manual install.
+  - Avoid network-dependent installs; mock or stub install paths where needed.
+- [x] Update any dev docs if required (only if solution adds a manual step).
+
+## Validation Criteria
+### Functional Validation
+- Issue 212:
+  - Archived sessions never appear in session list after load or fetch.
+  - Server `/session` returns filtered (and sorted) list without duplicate listing.
+- Issue 211:
+  - Create New builds correct path from parent + name and creates directory.
+  - Git Clone derives folder name from repo URL when blank.
+  - Name input rejects path separators and traversal sequences.
+  - Add Existing is unchanged and still works.
+- Issue 210:
+  - Running `bun dev` in repo loads `.opencode/tool` without import errors.
+  - Install guard prevents repeated installs on subsequent config loads.
+  - Production build behavior unaffected.
+
+### Test Execution (Required)
+- [x] Add tests for new/changed behaviors in `packages/opencode/test/`.
+- [x] Run tests before committing:
+  - `bun test` in `packages/opencode` (preferred for targeted tests)
+  - or `bun turbo test` at repo root
+
+## Open Questions / Decisions Needed
+- None. Decisions locked: Issue 210 uses Option A with guard; Issue 211 composes `path` in the client and uses `name` as metadata; Issue 212 includes server-side filtering and removes duplicate listing.
+
+(End of file)