|
| 1 | +import { describe, expect, test } from "bun:test" |
| 2 | +import path from "path" |
| 3 | +import type { Tool } from "../../src/tool/tool" |
| 4 | +import { Instance } from "../../src/project/instance" |
| 5 | +import { assertExternalDirectory } from "../../src/tool/external-directory" |
| 6 | +import type { PermissionNext } from "../../src/permission/next" |
| 7 | + |
| 8 | +const baseCtx: Omit<Tool.Context, "ask"> = { |
| 9 | + sessionID: "test", |
| 10 | + messageID: "", |
| 11 | + callID: "", |
| 12 | + agent: "build", |
| 13 | + abort: AbortSignal.any([]), |
| 14 | + metadata: () => {}, |
| 15 | +} |
| 16 | + |
| 17 | +describe("tool.assertExternalDirectory", () => { |
| 18 | + test("no-ops for empty target", async () => { |
| 19 | + const requests: Array<Omit<PermissionNext.Request, "id" | "sessionID" | "tool">> = [] |
| 20 | + const ctx: Tool.Context = { |
| 21 | + ...baseCtx, |
| 22 | + ask: async (req) => { |
| 23 | + requests.push(req) |
| 24 | + }, |
| 25 | + } |
| 26 | + |
| 27 | + await Instance.provide({ |
| 28 | + directory: "/tmp", |
| 29 | + fn: async () => { |
| 30 | + await assertExternalDirectory(ctx) |
| 31 | + }, |
| 32 | + }) |
| 33 | + |
| 34 | + expect(requests.length).toBe(0) |
| 35 | + }) |
| 36 | + |
| 37 | + test("no-ops for paths inside Instance.directory", async () => { |
| 38 | + const requests: Array<Omit<PermissionNext.Request, "id" | "sessionID" | "tool">> = [] |
| 39 | + const ctx: Tool.Context = { |
| 40 | + ...baseCtx, |
| 41 | + ask: async (req) => { |
| 42 | + requests.push(req) |
| 43 | + }, |
| 44 | + } |
| 45 | + |
| 46 | + await Instance.provide({ |
| 47 | + directory: "/tmp/project", |
| 48 | + fn: async () => { |
| 49 | + await assertExternalDirectory(ctx, path.join("/tmp/project", "file.txt")) |
| 50 | + }, |
| 51 | + }) |
| 52 | + |
| 53 | + expect(requests.length).toBe(0) |
| 54 | + }) |
| 55 | + |
| 56 | + test("asks with a single canonical glob", async () => { |
| 57 | + const requests: Array<Omit<PermissionNext.Request, "id" | "sessionID" | "tool">> = [] |
| 58 | + const ctx: Tool.Context = { |
| 59 | + ...baseCtx, |
| 60 | + ask: async (req) => { |
| 61 | + requests.push(req) |
| 62 | + }, |
| 63 | + } |
| 64 | + |
| 65 | + const directory = "/tmp/project" |
| 66 | + const target = "/tmp/outside/file.txt" |
| 67 | + const expected = path.join(path.dirname(target), "*") |
| 68 | + |
| 69 | + await Instance.provide({ |
| 70 | + directory, |
| 71 | + fn: async () => { |
| 72 | + await assertExternalDirectory(ctx, target) |
| 73 | + }, |
| 74 | + }) |
| 75 | + |
| 76 | + const req = requests.find((r) => r.permission === "external_directory") |
| 77 | + expect(req).toBeDefined() |
| 78 | + expect(req!.patterns).toEqual([expected]) |
| 79 | + expect(req!.always).toEqual([expected]) |
| 80 | + }) |
| 81 | + |
| 82 | + test("uses target directory when kind=directory", async () => { |
| 83 | + const requests: Array<Omit<PermissionNext.Request, "id" | "sessionID" | "tool">> = [] |
| 84 | + const ctx: Tool.Context = { |
| 85 | + ...baseCtx, |
| 86 | + ask: async (req) => { |
| 87 | + requests.push(req) |
| 88 | + }, |
| 89 | + } |
| 90 | + |
| 91 | + const directory = "/tmp/project" |
| 92 | + const target = "/tmp/outside" |
| 93 | + const expected = path.join(target, "*") |
| 94 | + |
| 95 | + await Instance.provide({ |
| 96 | + directory, |
| 97 | + fn: async () => { |
| 98 | + await assertExternalDirectory(ctx, target, { kind: "directory" }) |
| 99 | + }, |
| 100 | + }) |
| 101 | + |
| 102 | + const req = requests.find((r) => r.permission === "external_directory") |
| 103 | + expect(req).toBeDefined() |
| 104 | + expect(req!.patterns).toEqual([expected]) |
| 105 | + expect(req!.always).toEqual([expected]) |
| 106 | + }) |
| 107 | + |
| 108 | + test("skips prompting when bypass=true", async () => { |
| 109 | + const requests: Array<Omit<PermissionNext.Request, "id" | "sessionID" | "tool">> = [] |
| 110 | + const ctx: Tool.Context = { |
| 111 | + ...baseCtx, |
| 112 | + ask: async (req) => { |
| 113 | + requests.push(req) |
| 114 | + }, |
| 115 | + } |
| 116 | + |
| 117 | + await Instance.provide({ |
| 118 | + directory: "/tmp/project", |
| 119 | + fn: async () => { |
| 120 | + await assertExternalDirectory(ctx, "/tmp/outside/file.txt", { bypass: true }) |
| 121 | + }, |
| 122 | + }) |
| 123 | + |
| 124 | + expect(requests.length).toBe(0) |
| 125 | + }) |
| 126 | +}) |
0 commit comments