Skip to content

rebuild components#1050

Merged
ismellike merged 16 commits into
mainfrom
rebuild-components
Feb 24, 2026
Merged

rebuild components#1050
ismellike merged 16 commits into
mainfrom
rebuild-components

Conversation

@dakom
Copy link
Copy Markdown
Collaborator

@dakom dakom commented Oct 23, 2025

@ismellike latest wasi-build is still failing

@dakom dakom marked this pull request as ready for review October 23, 2025 04:47
@ismellike
Copy link
Copy Markdown
Collaborator

adding note might be osx specific since this branch ran CI fine #1049

also fixes building single components
@ismellike
Copy link
Copy Markdown
Collaborator

Can you try just wasi-build again? I have no idea how it was working before, but I went through and tried to match as best as possible with improvements. I am seeing this note on cw optimizer https://github.com/CosmWasm/optimizer?tab=readme-ov-file#notice. Still the greater question is how amd64 passes CI but arm64 build doesn't

@ismellike
Copy link
Copy Markdown
Collaborator

A diff between the two wasms shows a difference in wit versions used ❓ ❓ no idea how that's possible since all wit files are tracked and mounted with wit_bindgen using them in our example components :

<   (import "wavs:types/chain@2.0.0" (instance (;0;) (type 0)))
---
>   (import "wavs:types/chain@1.3.0" (instance (;0;) (type 0)))

@ueco-jb ueco-jb assigned ueco-jb and unassigned ueco-jb Nov 14, 2025
@ismellike
Copy link
Copy Markdown
Collaborator

can you give just wasi-build a run @dakom got a couple updates in on wasi-builder.

also fyi, needed to pin alloy-json-rpc

@dakom
Copy link
Copy Markdown
Collaborator Author

dakom commented Feb 23, 2026

@ismellike

good news: it built and passed the e2e tests 🚀

bad news: it created a diff of components, point of this is to have reproducible builds so that should not happen... if it's unavoidable for some reason, is what it is, but not sure why there would be a diff

@ismellike
Copy link
Copy Markdown
Collaborator

ismellike commented Feb 24, 2026

@ismellike

good news: it built and passed the e2e tests 🚀

bad news: it created a diff of components, point of this is to have reproducible builds so that should not happen... if it's unavoidable for some reason, is what it is, but not sure why there would be a diff

amazing! @dakom can you try once more, and I think we call it there regardless? Maybe we open an issue over on the wasi-builder repo for determinism.

@dakom
Copy link
Copy Markdown
Collaborator Author

dakom commented Feb 24, 2026

Still getting the diff, but it's building and passing tests, imho good to merge - agree we can move that issue to the builder :)

@ismellike ismellike merged commit 23fc6ed into main Feb 24, 2026
5 checks passed
@ismellike ismellike deleted the rebuild-components branch February 24, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants