Conversation
Contributor
|
Closing in favor of #1121 which builds on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High-level: we now have a desktop application. Binaries are built in CI: https://github.com/Lay3rLabs/WAVS/releases/tag/untagged-185c03da357a9e8aa36d
(we do not handle code-signing, so, depending on OS, you'll need to allow bypassing security etc.)
Pretty big change, lots to review, however:
packages/guidirectorywavschanges are minor:frontendpart, which can just be considered "if it looks right it is right" for nowimho this PR should be reviewed more from "did it break things" rather than "is it the only true way of doing it"
These videos show it working, especially part 2 (although a bit outdated since this PR was finalized, i.e. restart app works, a couple UI bugs fixed, release build fixed, all in all though it's pretty much the same experience):
The wizard project used for the videos can be found here: https://tinyurl.com/mna6frn8