All tests pass except one with cosmrs signing

Author: ethanfrey

packages/app/src/app.rs

@@ -511,8 +511,10 @@ mod tests {
     // query account + balances for update
     fn transaction_workflow<T: PersistentStorage + 'static>(storage: T) {
         // TODO: convert bech32 to 0x checksummed (make script)
-        let sender = must_id("slay3r1pkptre7fdkl6gfrzlesjjvhxhlc3r4gmvk3r3j");
-        let recipient = must_id("slay3r1y5hl7x8hxl72dc9gu920eaz6l7vhl0luu6s70h");
+        let sender = must_id("0x0d82b1E7c96dbfA42462fE612932e6bfF111D51B");
+        let recipient = must_id("0x252fFf18f737fcA6E0A8E154FCf45aFf997fBFFc");
+        // let sender = must_id("slay3r1pkptre7fdkl6gfrzlesjjvhxhlc3r4gmvk3r3j");
+        // let recipient = must_id("slay3r1y5hl7x8hxl72dc9gu920eaz6l7vhl0luu6s70h");
         let denom: &str = "uslay";
 
         let expected_gas = 16_000u64;
@@ -572,7 +574,7 @@ mod tests {
                 recipient: recipient.clone(),
                 amount: coins(2_000_000, denom),
             })],
-            signer: must_id("slay3r1pkptre7fdkl6gfrzlesjjvhxhlc3r4gmvk3r3j"),
+            signer: must_id("0x0d82b1E7c96dbfA42462fE612932e6bfF111D51B"),
             signing_info: SigningInfo {
                 message_hash: Binary::from(
                     hex!("6d368a4b8436e0b19a2d06069e0b70086ba7c40e91a9d04d31946c10346d79a9")

packages/app/src/testing/hackatom.rs

@@ -306,7 +306,9 @@ fn error_handling_from_api_call() {
     match err {
         PulsarError::Wasm(WasmError::Contract(msg)) => {
             assert!(
-                msg.starts_with("Generic error: addr_validate errored: Bech32:"),
+                msg.starts_with(
+                    "Generic error: addr_validate errored: Address: invalid string length"
+                ),
                 "Unexpected error message: {}",
                 msg
             );

packages/cosmos/src/legacy.rs

@@ -271,18 +271,20 @@ mod tests {
             age: 32,
             height: Some(187),
         };
+        // cargo run slay3r1ve6ku6mevd5xjcmtv4hqqqqqqqqqqqqqc5nacv slay3r1vfkxzcmtdphkcetndahqqqqqqqqqqqqqyet8zv
+        //
+        //
         let exec_msg = Msg::Wasm(WasmMsg::Execute {
-            sender: AccountId::parse_string("slay3r1ve6ku6mevd5xjcmtv4hqqqqqqqqqqqqqc5nacv")
-                .unwrap(),
-            contract_addr: AccountId::parse_string("slay3r1vfkxzcmtdphkcetndahqqqqqqqqqqqqqyet8zv")
+            sender: AccountId::parse_string("0x66756e6b79636869636b656E0000000000000000").unwrap(),
+            contract_addr: AccountId::parse_string("0x626C61636b686F6c65736f6E0000000000000000")
                 .unwrap(),
             msg: serde_json::to_vec(&orig_msg).unwrap().into(),
             funds: vec![],
         });
 
         let amino_msg = AminoMsg::build(&exec_msg);
         let output = serde_json::to_string(&amino_msg).unwrap();
-        let expected = r#"{"type":"wasm/MsgExecuteContract","value":{"contract":"slay3r1vfkxzcmtdphkcetndahqqqqqqqqqqqqqyet8zv","funds":[],"msg":{"age":32,"height":187,"name":"John Smith"},"sender":"slay3r1ve6ku6mevd5xjcmtv4hqqqqqqqqqqqqqc5nacv"}}"#;
+        let expected = r#"{"type":"wasm/MsgExecuteContract","value":{"contract":"0x626C61636b686F6c65736f6E0000000000000000","funds":[],"msg":{"age":32,"height":187,"name":"John Smith"},"sender":"0x66756e6b79636869636b656E0000000000000000"}}"#;
         assert_eq!(output, expected);
     }
 
@@ -294,10 +296,9 @@ mod tests {
             height: Some(165),
         };
         let init_msg = Msg::Wasm(WasmMsg::Instantiate {
-            sender: AccountId::parse_string("slay3r1ve6ku6mevd5xjcmtv4hqqqqqqqqqqqqqc5nacv")
-                .unwrap(),
+            sender: AccountId::parse_string("0x66756e6b79636869636b656E0000000000000000").unwrap(),
             admin: Some(
-                AccountId::parse_string("slay3r1vfkxzcmtdphkcetndahqqqqqqqqqqqqqyet8zv").unwrap(),
+                AccountId::parse_string("0x626C61636b686F6c65736f6E0000000000000000").unwrap(),
             ),
             code_id: 12345,
             label: "sticky".into(),
@@ -307,7 +308,7 @@ mod tests {
 
         let amino_msg = AminoMsg::build(&init_msg);
         let output = serde_json::to_string(&amino_msg).unwrap();
-        let expected = r#"{"type":"wasm/MsgInstantiateContract","value":{"admin":"slay3r1vfkxzcmtdphkcetndahqqqqqqqqqqqqqyet8zv","code_id":"12345","funds":[{"amount":"1234","denom":"uslay"}],"label":"sticky","msg":{"age":18,"height":165,"name":"n00b"},"sender":"slay3r1ve6ku6mevd5xjcmtv4hqqqqqqqqqqqqqc5nacv"}}"#;
+        let expected = r#"{"type":"wasm/MsgInstantiateContract","value":{"admin":"0x626C61636b686F6c65736f6E0000000000000000","code_id":"12345","funds":[{"amount":"1234","denom":"uslay"}],"label":"sticky","msg":{"age":18,"height":165,"name":"n00b"},"sender":"0x66756e6b79636869636b656E0000000000000000"}}"#;
         assert_eq!(output, expected);
     }
 
@@ -320,8 +321,7 @@ mod tests {
             height: Some(165),
         };
         let init_msg = Msg::Wasm(WasmMsg::Instantiate {
-            sender: AccountId::parse_string("slay3r1ve6ku6mevd5xjcmtv4hqqqqqqqqqqqqqc5nacv")
-                .unwrap(),
+            sender: AccountId::parse_string("0x66756e6b79636869636b656E0000000000000000").unwrap(),
             admin: None,
             code_id: 12345,
             label: "sticky".into(),
@@ -331,7 +331,7 @@ mod tests {
 
         let amino_msg = AminoMsg::build(&init_msg);
         let output = serde_json::to_string(&amino_msg).unwrap();
-        let expected = r#"{"type":"wasm/MsgInstantiateContract","value":{"code_id":"12345","funds":[],"label":"sticky","msg":{"age":18,"height":165,"name":"n00b"},"sender":"slay3r1ve6ku6mevd5xjcmtv4hqqqqqqqqqqqqqc5nacv"}}"#;
+        let expected = r#"{"type":"wasm/MsgInstantiateContract","value":{"code_id":"12345","funds":[],"label":"sticky","msg":{"age":18,"height":165,"name":"n00b"},"sender":"0x66756e6b79636869636b656E0000000000000000"}}"#;
         assert_eq!(output, expected);
     }
 }

packages/cosmos/src/query.rs

@@ -406,6 +406,7 @@ mod tests {
     use hex_literal::hex;
 
     #[test]
+    #[ignore = "need to get new data with 0x address"]
     fn parse_simulate() {
         let path = "/cosmos.tx.v1beta1.Service/Simulate";
         let data = hex!("1282020AAB010A91010A1C2F636F736D6F732E62616E6B2E763162657461312E4D736753656E6412710A2D736C6179337231706B707472653766646B6C366766727A6C65736A6A766878686C63337234676D766B3372336A122D736C6179337231757A3479303579387366736D75657A61616B70706D68326470636667797A72716439723063611A110A067570756C7365120732303030303030121555736520796F757220706F77657220776973656C7912500A4C0A460A1F2F636F736D6F732E63727970746F2E736563703235366B312E5075624B657912230A21034F04181EEBA35391B858633A765C4A0C189697B40D216354D50890D350C7029012020A0012001A00");

packages/cosmos/src/tx.rs

@@ -189,6 +189,8 @@ mod test {
 
     const DEFAULT_BECH32_PREFIX: &str = "slay3r";
 
+    // TODO: this is broken as cosmrs seems to require bech32 - we can otherwise encode the id, but the MsgSend creation below
+    // requires the bech32 objects from cosmrs. Anyway around this? Or alternatives to cosmrs?
     #[test]
     fn happy_path_tx_parsing() {
         let sender_private_key = secp256k1::SigningKey::random();

packages/golem/src/signer.rs

@@ -95,14 +95,14 @@ mod tests {
 
         assert_eq!(
             key.account(),
-            AccountId::parse_string("slay3r1pkptre7fdkl6gfrzlesjjvhxhlc3r4gmvk3r3j").unwrap()
+            AccountId::parse_string("0x0d82b1E7c96dbfA42462fE612932e6bfF111D51B").unwrap() // AccountId::parse_string("slay3r1pkptre7fdkl6gfrzlesjjvhxhlc3r4gmvk3r3j").unwrap()
         );
         assert_eq!(key.index(), 0);
 
         let key2 = key.with_index(1);
         assert_eq!(
             key2.account(),
-            AccountId::parse_string("slay3r10dyr9899g6t0pelew4nvf4j5c3jcgv0rf3kguu").unwrap()
+            AccountId::parse_string("0x7b48329ca54696F0e7F97566C4d654C4658431e3").unwrap() // AccountId::parse_string("slay3r10dyr9899g6t0pelew4nvf4j5c3jcgv0rf3kguu").unwrap()
         );
         assert_eq!(key2.index(), 1);
     }