fix(mempool): make initial-sync tx insertion idempotent#61
Open
torkelrogstad wants to merge 1 commit into
Open
fix(mempool): make initial-sync tx insertion idempotent#61torkelrogstad wants to merge 1 commit into
torkelrogstad wants to merge 1 commit into
Conversation
Skip re-inserting a tx already in the mempool instead of failing the whole sync task with TxAlreadyExists. The RPC snapshot and live ZMQ sequence stream can queue the same txid twice.
Ash-L2L
requested changes
Jun 30, 2026
| // `Mempool::insert` fail with `TxAlreadyExists` and abort the whole sync | ||
| // task, so treat an already-present tx as a successfully-applied no-op. | ||
| if inner.mempool.txs.0.contains_key(&txid) { | ||
| inner.unfiltered_mempool.txs.insert(txid); |
Collaborator
There was a problem hiding this comment.
I don't think this is correct - the filtered mempool should always be a subset of the unfiltered mempool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip re-inserting a tx already in the mempool instead of failing the whole sync task with TxAlreadyExists. The RPC snapshot and live ZMQ sequence stream can queue the same txid twice.
Reported here: LayerTwo-Labs/bip300301_enforcer#406