fix: get_block_template can assemble over-weight blocks (M6 suffix not weight-budgeted)#64
Closed
giaki3003 wants to merge 1 commit into
Conversation
giaki3003
force-pushed
the
fix/s3-r10-get-block-template-can-assemble-over-weight-bloc
branch
from
July 4, 2026 17:03
9a89895 to
319188a
Compare
…t weight-budgeted) Bug: s3-r10 (primary) Finding: Severity: Medium Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit 319188a)
giaki3003
force-pushed
the
fix/s3-r10-get-block-template-can-assemble-over-weight-bloc
branch
from
July 7, 2026 12:23
319188a to
24389cf
Compare
Ash-L2L
requested changes
Jul 15, 2026
Ash-L2L
left a comment
Ash-L2L
left a comment
Collaborator
There was a problem hiding this comment.
It would be better to modify cusf_block_producer::InitialBlockTemplate / cusf_block_producer::BlockTemplateSuffix / cusf_block_producer::CusfBlockProducer
such that CusfBlockProducer::initial_block_template can add some suffix txs to a block template, or reserve space for them to be added in CusfBlockProducer::block_template_suffix.
I will open a separate PR for this.
For bip300301_enforcer, the M6 suffix txs are available before filling the block template with mempool txs, so they could be included in CusfBlockProducer::initial_block_template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reserve the block-template suffix (M6) weight in the mempool tx weight budget so
get_block_templatecannot assemble over-weight blocksThe bug
get_block_template can assemble over-weight blocks (M6 suffix not weight-budgeted)
Severity: Medium. Full technical write-up (access-controlled):
Notes
First of a short series of fixes for this repo from a security review; the remaining fixes stack on this branch and will follow as separate PRs. Happy to adjust scope or split further on request.