give better error when signet is down when depositing on a sidechain#1823
Open
ekulkisnek wants to merge 1 commit into
Open
give better error when signet is down when depositing on a sidechain#1823ekulkisnek wants to merge 1 commit into
ekulkisnek wants to merge 1 commit into
Conversation
octobocto
requested changes
Jun 11, 2026
Comment on lines
+12
to
+27
| /// Maps orchestrator [WalletMetadata.walletType] strings to [BinaryType]. | ||
| /// Proto values are `enforcer` / `bitcoinCore` / `watchOnly`, not enum names. | ||
| BinaryType walletBinaryTypeFromProto(String raw) { | ||
| switch (raw) { | ||
| case 'enforcer': | ||
| return BinaryType.BINARY_TYPE_ENFORCER; | ||
| case 'bitcoinCore': | ||
| case 'bitcoind': | ||
| return BinaryType.BINARY_TYPE_BITCOIND; | ||
| case 'watchOnly': | ||
| return BinaryType.BINARY_TYPE_BITCOIND; | ||
| default: | ||
| return BinaryType.BINARY_TYPE_BITCOIND; | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
You should rebase on master and remove this. Not needed anymore with the newest types. Same goes for walletTypeRaw and the test
Comment on lines
+1875
to
+1879
| if isStaleWalletTransactionError(err) { | ||
| txs = connect.NewResponse(&validatorpb.ListTransactionsResponse{}) | ||
| } else { | ||
| return nil, err | ||
| } |
Collaborator
There was a problem hiding this comment.
This should be handled in the client(s)!
An error is not the same as zero transactions, and can mislead people to thinking their deposits are gone. Only zero transactions should be zero transactions!
Comment on lines
+82
to
+86
| } catch (e, st) { | ||
| // Deposits are optional for listing active sidechains; enforcer may | ||
| // return "no treasury utxo yet" before the first deposit on a slot. | ||
| log.w('listSidechainDeposits slot ${sidechain.slot}: $e', stackTrace: st); | ||
| } |
Collaborator
There was a problem hiding this comment.
Then we should specifically handle the no treasury utxo yet error message, or save the error message and display it to the user. Not swallow it.
ekulkisnek
force-pushed
the
fix/bitwindow-sidechain-deposit-errors
branch
from
June 16, 2026 19:19
89fcf0f to
6c312be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signet was down and there were two of the same transaction in the mempool.
When blocks are stalled this pr edits the behavior to emit a better error