Skip to content

give better error when signet is down when depositing on a sidechain #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekulkisnek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

give better error when signet is down when depositing on a sidechain #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion bitwindow/server/api/wallet/wallet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,16 @@ type Server struct {
walletDir string
}

func isNonFinalTransactionError(err error) bool {
return err != nil && strings.Contains(err.Error(), "non-final")
}

func isInsufficientReplacementFeeError(err error) bool {
return err != nil &&
strings.Contains(err.Error(), "insufficient fee") &&
strings.Contains(err.Error(), "rejecting replacement")
}

// CreateBitcoinCoreWallet implements walletv1connect.WalletServiceHandler.
// Test endpoint to verify descriptor import to Bitcoin Core.
func (s *Server) CreateBitcoinCoreWallet(ctx context.Context, c *connect.Request[pb.CreateBitcoinCoreWalletRequest]) (*connect.Response[pb.CreateBitcoinCoreWalletResponse], error) {
Expand Down Expand Up @@ -1175,6 +1185,10 @@ func (s *Server) ListSidechainDeposits(ctx context.Context, c *connect.Request[p

deposits, err := s.data.ListSidechainDeposits(ctx, &validatorpb.ListSidechainDepositTransactionsRequest{})
if err != nil {
// No treasury UTXO indexed yet for an active slot (common on fresh signet).
if strings.Contains(err.Error(), "Missing value from db") {
return connect.NewResponse(&pb.ListSidechainDepositsResponse{}), nil
}
return nil, fmt.Errorf("enforcer/wallet: could not list sidechain deposits: %w", err)
}

Expand Down Expand Up @@ -1250,6 +1264,12 @@ func (s *Server) CreateSidechainDeposit(ctx context.Context, c *connect.Request[
FeeSats: &wrapperspb.UInt64Value{Value: uint64(fee)},
}))
if err != nil {
if isNonFinalTransactionError(err) {
return nil, connect.NewError(connect.CodeFailedPrecondition, errors.New("deposit transaction is not final yet; wait for the next mainchain block, then check deposits or retry"))
}
if isInsufficientReplacementFeeError(err) {
return nil, connect.NewError(connect.CodeFailedPrecondition, errors.New("a deposit from this wallet is already waiting in the mainchain mempool; wait for the next mainchain block, then check deposits or retry"))
}
return nil, fmt.Errorf("enforcer/wallet: could not create deposit transaction: %w", err)
}

Expand Down Expand Up @@ -1879,7 +1899,11 @@ func (s *Server) GetStats(ctx context.Context, c *connect.Request[pb.GetStatsReq
// 3. Get all sidechain deposit transactions and sum their amounts
sidechainDeposits, err := s.data.ListSidechainDeposits(ctx, &validatorpb.ListSidechainDepositTransactionsRequest{})
if err != nil {
return nil, err
if strings.Contains(err.Error(), "Missing value from db") {
sidechainDeposits = &validatorpb.ListSidechainDepositTransactionsResponse{}
} else {
return nil, err
}
}
var depositSum int64
var depositSumLast30Days int64
Expand Down