Backport Thunder 0.15.0 - #40
Merged
Merged
Conversation
Avoid generating and writing a new wallet address to LMDB every time the GUI application starts up, which could lead to performance degradation. Instead, reuse the last generated address on initialization, and only generate a new address on user demand (via explicit 'generate' button).
`AggregatedWithdrawal`'s `Ord` impl is not a valid total order: it returns `Greater` if any of `main_fee`, `value`, or `main_address` is greater (an OR of `>`), which violates antisymmetry and transitivity. `collect_withdrawal_bundle` aggregates withdrawals into a `HashMap`, takes `into_values()` (iteration order is randomized per process) and `sort_by_key`s with that comparator. Because the comparator is non-transitive the sorted order depends on the input order, and nothing canonicalizes it before the bundle's outputs are hashed into the m6id (`compute_txid`). Two honest nodes with the identical UTXO set can therefore compute different m6ids for the same withdrawal bundle, then disagree on the on-chain M6 and diverge. Replace the comparator with a real total order (lexicographic over `(main_fee, value, main_address)`) so the sorted bundle is canonical regardless of `HashMap` iteration order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.