Merge branch 'main' into codex/identify-devex-gaps-in-lzapp-migration

Author: nazreen

examples/oft-hyperliquid/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @layerzerolabs/oft-hyperliquid-example
 
+## 0.0.8
+
+### Patch Changes
+
+- 9c0c90c: using CoreWriter instead of WritePrecompile
+
 ## 0.0.7
 
 ### Patch Changes

examples/oft-hyperliquid/HYPERLIQUID.CHECKLIST.md

@@ -104,6 +104,7 @@ Block switching is not present in the default oft deploy script.
 - [ ] Follow the [guide](https://github.com/LayerZero-Labs/devtools/blob/main/examples/oft-hyperliquid/HYPERLIQUID.README.md#step-56-createspotdeployment)
 - Step MUST be run even though we set `noHyperliquidity=true` in genesis
 - This can be run even after deployment and linking
+- [ ] Run this step only before market makers are ready to provide liquidity. Otherwise users can trade your token at arbitrary prices.
 
 ### Step 2.6 : Set deployer fee share
 

examples/oft-hyperliquid/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@layerzerolabs/oft-hyperliquid-example",
-  "version": "0.0.7",
+  "version": "0.0.8",
   "private": true,
   "license": "MIT",
   "scripts": {
@@ -27,7 +27,7 @@
     "@babel/core": "^7.23.9",
     "@layerzerolabs/devtools-evm-hardhat": "^3.0.0",
     "@layerzerolabs/eslint-config-next": "~2.3.39",
-    "@layerzerolabs/hyperliquid-composer": "^0.0.12",
+    "@layerzerolabs/hyperliquid-composer": "^0.0.13",
     "@layerzerolabs/lz-definitions": "^3.0.59",
     "@layerzerolabs/lz-evm-messagelib-v2": "^3.0.12",
     "@layerzerolabs/lz-evm-protocol-v2": "^3.0.12",

examples/oft-hyperliquid/test/foundry/HyperLiquidComposer.t.sol

@@ -8,10 +8,7 @@ import { OFTComposeMsgCodec } from "@layerzerolabs/oft-evm/contracts/libs/OFTCom
 import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 
 import { HyperLiquidComposer, IHyperAsset } from "@layerzerolabs/hyperliquid-composer/contracts/HyperLiquidComposer.sol";
-import { IHyperLiquidWritePrecompile } from "@layerzerolabs/hyperliquid-composer/contracts/interfaces/IHyperLiquidWritePrecompile.sol";
-
-import { HyperLiquidComposer, IHyperAsset } from "@layerzerolabs/hyperliquid-composer/contracts/HyperLiquidComposer.sol";
-import { IHyperLiquidWritePrecompile } from "@layerzerolabs/hyperliquid-composer/contracts/interfaces/IHyperLiquidWritePrecompile.sol";
+import { ICoreWriter } from "@layerzerolabs/hyperliquid-composer/contracts/interfaces/ICoreWriter.sol";
 
 import { HyperLiquidComposerCodec } from "@layerzerolabs/hyperliquid-composer/contracts/library/HyperLiquidComposerCodec.sol";
 
@@ -25,7 +22,7 @@ contract HyperLiquidComposerTest is Test {
     IHyperAsset public ALICE;
     IHyperAsset public HYPE;
     address public constant HL_LZ_ENDPOINT_V2 = 0xf9e1815F151024bDE4B7C10BAC10e8Ba9F6b53E1;
-    address public constant HLP_PRECOMPILE_WRITE = 0x3333333333333333333333333333333333333333;
+    address public constant HLP_CORE_WRITER = 0x3333333333333333333333333333333333333333;
     address public constant HLP_PRECOMPILE_READ_SPOT_BALANCE = 0x0000000000000000000000000000000000000801;
     // Ethereum Sepolia
     uint32 public constant SRC_EID = 40161;
@@ -124,14 +121,11 @@ contract HyperLiquidComposerTest is Test {
         vm.expectEmit(address(oft));
         emit IERC20.Transfer(address(hyperLiquidComposer), ALICE.assetBridgeAddress, AMOUNT_TO_SEND);
 
-        // Expect the SpotSend event to be emitted
-        vm.expectEmit(hyperLiquidComposer.HLP_PRECOMPILE_WRITE());
-        emit IHyperLiquidWritePrecompile.SpotSend(
-            address(hyperLiquidComposer),
-            userB,
-            ALICE.coreIndexId,
-            uint64(AMOUNT_TO_SEND / 10 ** uint64(ALICE.decimalDiff))
-        );
+        uint64 coreAmount = hyperLiquidComposer.quoteHyperCoreAmount(AMOUNT_TO_SEND, true).core;
+        bytes memory action = abi.encode(userB, ALICE.coreIndexId, coreAmount);
+        bytes memory payload = abi.encodePacked(hyperLiquidComposer.SPOT_SEND_HEADER(), action);
+        vm.expectEmit(HLP_CORE_WRITER);
+        emit ICoreWriter.RawAction(address(hyperLiquidComposer), payload);
 
         uint256 balanceBefore = oft.balanceOf(userB);
 
@@ -165,14 +159,11 @@ contract HyperLiquidComposerTest is Test {
         vm.expectEmit(address(oft));
         emit IERC20.Transfer(address(hyperLiquidComposer), ALICE.assetBridgeAddress, AMOUNT_TO_SEND);
 
-        // Expect the SpotSend event to be emitted - this is for the ALICE asset bridge
-        vm.expectEmit(hyperLiquidComposer.HLP_PRECOMPILE_WRITE());
-        emit IHyperLiquidWritePrecompile.SpotSend(
-            address(hyperLiquidComposer),
-            userB,
-            ALICE.coreIndexId,
-            uint64(AMOUNT_TO_SEND / 10 ** uint64(ALICE.decimalDiff))
-        );
+        uint64 coreAmount = hyperLiquidComposer.quoteHyperCoreAmount(AMOUNT_TO_SEND, true).core;
+        bytes memory action = abi.encode(userB, ALICE.coreIndexId, coreAmount);
+        bytes memory payload = abi.encodePacked(hyperLiquidComposer.SPOT_SEND_HEADER(), action);
+        vm.expectEmit(HLP_CORE_WRITER);
+        emit ICoreWriter.RawAction(address(hyperLiquidComposer), payload);
 
         uint256 balanceBeforeBridge = HYPE.assetBridgeAddress.balance;
         uint256 balanceBeforeUserB = userB.balance;

packages/hyperliquid-composer/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @layerzerolabs/hyperliquid-composer
 
+## 0.0.13
+
+### Patch Changes
+
+- 9c0c90c: using CoreWriter instead of WritePrecompile
+
 ## 0.0.12
 
 ### Patch Changes

packages/hyperliquid-composer/HYPERLIQUID.README.md

@@ -118,7 +118,7 @@ The system contracts are:
 and `L1ActionPrecompiles`
 
 - `0x0000000000000000000000000000000000000000` is one of the many `L1Read` precompiles.
-- `0x3333333333333333333333333333333333333333` is the `L1WritePrecompile` and is used to send transactions to HyperCore.
+- `0x3333333333333333333333333333333333333333` is the `CoreWriter` and is used to send transactions to HyperCore.
 
 More `L1ActionPrecompiles` found [here](https://hyperliquid.gitbook.io/hyperliquid-docs/for-developers/hyperevm/interacting-with-hypercore).
 
@@ -229,7 +229,7 @@ struct SendParam {
 }
 ```
 
-Now that the token is with the `Composer` on HyperCore it then performs a `L1WritePrecompile` transaction to `0x33...333` (the `L1WritePrecompile` address) telling it to perform a `spot transfer` of the tokens from it's address to the `receiver`.
+Now that the token is with the `Composer` on HyperCore it then performs a `CoreWriter` transaction to `0x33...333` (the `CoreWriter` address) telling it to perform a `spot transfer` of the tokens from it's address to the `receiver`.
 
 It must be noted that due to the token decimal difference between the `EVM::ERC20` and `HyperCore::HIP1` the tokens you see on `HyperCore` would be different with the wei decimal different (`HIP1.decimals()` - `ERC20.decimals()` in range `[-2,18]`). But when converting them back from `HyperCore` to `HyperEVM` the token decimals gets restored.
 
@@ -284,11 +284,16 @@ function _sendAssetToHyperCore(
 
   if (amounts.evm > 0) {
     token.safeTransfer(oftAsset.assetBridgeAddress, amounts.evm);
-    IHyperLiquidWritePrecompile(HLP_PRECOMPILE_WRITE).sendSpot(
+    bytes memory action = abi.encodePacked(
       _receiver,
       oftAsset.coreIndexId,
       amounts.core
     );
+    bytes memory payload = abi.encodePacked(
+      abi.encodePacked(hex"1600", action) // 1600 is the [version][actionId][actionBytes] - https://hyperliquid.gitbook.io/hyperliquid-docs/for-developers/hyperevm/interacting-with-hypercore#action-encoding-details
+    );
+    /// Transfers tokens from the composer address on HyperCore to the _receiver
+    ICoreWriter(HLP_PRECOMPILE_WRITE).sendRawAction(payload);
   }
   if (amounts.dust > 0) {
     token.safeTransfer(_receiver, amounts.dust);