issue-11: remove duplication in constructor - IOFT.decimalConversionRate()

shankars99 · shankars99 · commit b8258f14c37d · 2025-07-16T16:24:02.000Z
Signed-off-by: shankar &lt;shankar@layerzerolabs.org&gt;
diff --git a/packages/ovault-evm/contracts/OVaultComposer.sol b/packages/ovault-evm/contracts/OVaultComposer.sol
@@ -66,9 +66,6 @@ contract OVaultComposer is IOVaultComposer, ReentrancyGuard {
         // Approve the shareOFTAdapter with the share tokens held by this contract
         IERC20(IOFT(_shareOFT).token()).approve(_shareOFT, type(uint256).max);
 
-        ASSET_DECIMAL_CONVERSION_RATE = IOFT(_assetOFT).decimalConversionRate();
-        SHARE_DECIMAL_CONVERSION_RATE = IOFT(_shareOFT).decimalConversionRate();
-
         REFUND_OVERPAY_ADDRESS = _refundOverpayAddress;
         ASSET_ERC20 = address(OVAULT.asset());
     }

Original file line number	Diff line number	Diff line change
`@@ -66,9 +66,6 @@ contract OVaultComposer is IOVaultComposer, ReentrancyGuard {`
`66`	`66`	`// Approve the shareOFTAdapter with the share tokens held by this contract`
`67`	`67`	`IERC20(IOFT(_shareOFT).token()).approve(_shareOFT, type(uint256).max);`
`68`	`68`
`69`		`- ASSET_DECIMAL_CONVERSION_RATE = IOFT(_assetOFT).decimalConversionRate();`
`70`		`- SHARE_DECIMAL_CONVERSION_RATE = IOFT(_shareOFT).decimalConversionRate();`
`71`		`-`
`72`	`69`	`REFUND_OVERPAY_ADDRESS = _refundOverpayAddress;`
`73`	`70`	`ASSET_ERC20 = address(OVAULT.asset());`
`74`	`71`	`}`