Ovault - audit paladin (#1652)

Signed-off-by: shankar <shankar@layerzerolabs.org>

Author: shankars99

packages/ovault-evm/contracts/VaultComposerSync.sol

@@ -2,7 +2,7 @@
 pragma solidity ^0.8.22;
 
 import { SafeERC20, IERC20 } from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
-import { IERC4626 } from "@openzeppelin/contracts/interfaces/IERC4626.sol";
+import { ERC4626, IERC4626 } from "@openzeppelin/contracts/token/ERC20/extensions/ERC4626.sol";
 
 import { ReentrancyGuard } from "@openzeppelin/contracts/utils/ReentrancyGuard.sol";
 
@@ -273,22 +273,34 @@ contract VaultComposerSync is IVaultComposerSync, ReentrancyGuard {
     /**
      * @notice Quotes the send operation for the given OFT and SendParam
      * @dev Revert on slippage will be thrown by the OFT and not _assertSlippage
+     * @param _from The "sender address" used for the quote
      * @param _targetOFT The OFT contract address to quote
      * @param _vaultInAmount The amount of tokens to send to the vault
      * @param _sendParam The parameters for the send operation
      * @return MessagingFee The estimated fee for the send operation
      * @dev This function can be overridden to implement custom quoting logic
      */
     function quoteSend(
+        address _from,
         address _targetOFT,
         uint256 _vaultInAmount,
         SendParam memory _sendParam
     ) external view virtual returns (MessagingFee memory) {
         /// @dev When quoting the asset OFT, the function input is shares and the SendParam.amountLD into quoteSend() should be assets (and vice versa)
 
         if (_targetOFT == ASSET_OFT) {
+            uint256 maxRedeem = VAULT.maxRedeem(_from);
+            if (_vaultInAmount > maxRedeem) {
+                revert ERC4626.ERC4626ExceededMaxRedeem(_from, _vaultInAmount, maxRedeem);
+            }
+
             _sendParam.amountLD = VAULT.previewRedeem(_vaultInAmount);
         } else {
+            uint256 maxDeposit = VAULT.maxDeposit(_from);
+            if (_vaultInAmount > maxDeposit) {
+                revert ERC4626.ERC4626ExceededMaxDeposit(_from, _vaultInAmount, maxDeposit);
+            }
+
             _sendParam.amountLD = VAULT.previewDeposit(_vaultInAmount);
         }
         return IOFT(_targetOFT).quoteSend(_sendParam, false);

packages/ovault-evm/contracts/interfaces/IVaultComposerSync.sol

@@ -56,13 +56,15 @@ interface IVaultComposerSync is IOAppComposer {
 
     /**
      * @notice Quotes the send operation for the given OFT and SendParam
+     * @param from The "sender address" used for the quote
      * @param targetOft The OFT contract address to quote
      * @param vaultInAmount The amount of tokens to send to the vault
      * @param sendParam The parameters for the send operation
      * @return MessagingFee The estimated fee for the send operation
      * @dev This function can be overridden to implement custom quoting logic
      */
     function quoteSend(
+        address from,
         address targetOft,
         uint256 vaultInAmount,
         SendParam memory sendParam

packages/ovault-evm/test/vault-sync/VaultComposerSync_ProxySend.t.sol

@@ -102,7 +102,12 @@ contract VaultComposerSyncProxySendTest is VaultComposerSyncBaseTest {
         SendParam memory sendParam = SendParam(POL_EID, addressToBytes32(userA), TOKENS_TO_SEND, 0, "", "", "");
         assetOFT_arb.mint(address(userA), TOKENS_TO_SEND);
 
-        MessagingFee memory fee = VaultComposerSyncArb.quoteSend(address(assetOFT_arb), TOKENS_TO_SEND, sendParam);
+        MessagingFee memory fee = VaultComposerSyncArb.quoteSend(
+            userA,
+            address(shareOFT_arb),
+            TOKENS_TO_SEND,
+            sendParam
+        );
 
         vm.startPrank(userA);
         assetOFT_arb.approve(address(VaultComposerSyncArb), TOKENS_TO_SEND);
@@ -123,7 +128,12 @@ contract VaultComposerSyncProxySendTest is VaultComposerSyncBaseTest {
         assetOFT_arb.mint(address(vault_arb), TOKENS_TO_SEND);
         vault_arb.mint(address(userA), TOKENS_TO_SEND);
 
-        MessagingFee memory fee = VaultComposerSyncArb.quoteSend(address(shareOFT_arb), TOKENS_TO_SEND, sendParam);
+        MessagingFee memory fee = VaultComposerSyncArb.quoteSend(
+            userA,
+            address(assetOFT_arb),
+            TOKENS_TO_SEND,
+            sendParam
+        );
 
         vm.startPrank(userA);
         vault_arb.approve(address(VaultComposerSyncArb), TOKENS_TO_SEND);