feat(examples/lzapp-migration): unified send task + align DevEx with oft-solana - #1527
Merged
Conversation
St0rmBr3w
reviewed
May 29, 2025
Contributor
Author
|
CI is failing due to unrelated reason (hyperliquid) |
Contributor
Author
|
CI is all green as of 16 days ago |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the lzapp-migration example with the oft-solana patterns, introduces a unified lz:oft:send task for both EVM and Solana, and enhances DevEx tooling for Solana (notably by using getSolanaKeypair and adding a debug command).
- Introduce
sendSolana,sendEvm, and a top-levellz:oft:sendtask for unified cross-chain sends - Swap direct env-key loading for
getSolanaKeypairin Solana helpers and add adebugtask - Update
.env.example, ESLint config, and task exports to support new tooling
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| examples/oft-solana/.env.example | Grouped EVM vars, added Solana-specific env settings |
| examples/lzapp-migration/tasks/solana/utils.ts | Added parseDecimalToUnits and silenceSolana429 helpers |
| examples/lzapp-migration/tasks/solana/index.ts | Refactored deriveConnection and useWeb3Js to use getSolanaKeypair |
| examples/lzapp-migration/tasks/index.ts | Swapped in unified send task and new Solana commands |
Comments suppressed due to low confidence (3)
examples/lzapp-migration/tasks/index.ts:13
- There is no
setAuthority.tsfile in the solana tasks directory; it looks like this should importsetUpdateAuthority.tsinstead.
import './solana/setAuthority'
examples/lzapp-migration/tasks/index.ts:14
- No
updateMetadata.tsexists in the solana folder; verify the correct filename or remove this import.
import './solana/updateMetadata'
examples/lzapp-migration/tasks/index.ts:16
- There is no
getPrioFees.tsmodule in the solana tasks; confirm the intended file or update the import path.
import './solana/getPrioFees'
St0rmBr3w
reviewed
Jul 14, 2025
St0rmBr3w
reviewed
Jul 14, 2025
St0rmBr3w
left a comment
Contributor
There was a problem hiding this comment.
Minor comments, otherwise looks good
shankars99
pushed a commit
that referenced
this pull request
Jul 20, 2025
mattsse
pushed a commit
to mattsse/devtools
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was inited by Codex but had to be manually edited afterwards. Manual send testing was also done.
Summary
oft-solana.env.exampleto also contain Solana variablesAffected tasks
My Tests
Solana to Sepolia - https://testnet.layerzeroscan.com/tx/38FAXsTFuGxNVbbJFVpRD4Y3NoTPAWHpDUzvcAQBryueDBkoT35WCg8dVXPNZkUQPuLXaJtiHsqHCZTdAyYAEgmY
Sepolia to Solana - https://testnet.layerzeroscan.com/tx/0xccbe7cdc8423f6ccf16174c81d01535005203681d92ac6da0f9280dcbf80a5e9
How you can test
Send
Make sure you have called setMinDstGas:
Deploy as usual.
Run the send tasks.
Sepolia V1 to Solana:
Solana to Sepolia V1
Debug
Without needing to deploy:
If you deployed (uses solana deployment file):