feat: Synchronous Vault Composers - #1584
Conversation
1c9b2e0 to
6c523ed
Compare
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
a821e27 to
b8258f1
Compare
de69735 to
d898f24
Compare
|
@shankars99 can we remove the pending audit label? |
It's ongoing, we're waiting on the second audit. Once it's back I'll take it off and we can merge |
yota-toyama-lz
left a comment
There was a problem hiding this comment.
I just finished looking at some example files. As I'm a newbie, some of them are more like questions. But if you can answer them, I would appreciate that!
yota-toyama-lz
left a comment
There was a problem hiding this comment.
I looked at the main contract codes. So I'm submitting partial reviews on them. Some of them are already answered by @TRileySchwarz as they are resolved.
Again, I'm a blockchain newbie. So if anything doesn't make any sense, let me know!
f7a1863 to
8751ec2
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Signed-off-by: shankar <shankar@layerzerolabs.org> feat: ovault composer (#1583) Signed-off-by: shankar <shankar@layerzerolabs.org> rename: ovault-composer-evm to ovault-evm (#1587) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault examples (#1588) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault example changes (#1590) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault cleanup #1 (#1594) Signed-off-by: shankar <shankar@layerzerolabs.org> audit patches + improvement (#1600) Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/improvements (#1603) Signed-off-by: shankar <shankar@layerzerolabs.org> example to match package Signed-off-by: shankar <shankar@layerzerolabs.org> virtual on _executeOVaultAction Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/source is hub (#1606) Signed-off-by: shankar <shankar@layerzerolabs.org> fix: deposit actions (#1610) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault - standardize event emitted during entry of failed state in lzCompose (#1611) Signed-off-by: shankar <shankar@layerzerolabs.org> update to match package Signed-off-by: shankar <shankar@layerzerolabs.org> issue-5: skip removeDust() on slippage check when dstEid=hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-9: token.safeTransfer(..args) instead of transfer Signed-off-by: shankar <shankar@layerzerolabs.org> issue-4: refuse msg.value on proxySend() when dstEid is the hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-12: remove duplicated safeERC20 import and library usage Signed-off-by: shankar <shankar@layerzerolabs.org> issue-13: initialize() for upgradeable Signed-off-by: shankar <shankar@layerzerolabs.org> issue-14: remove unused interface errors Signed-off-by: shankar <shankar@layerzerolabs.org> to match packages Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in retry() Signed-off-by: shankar <shankar@layerzerolabs.org> copy-pasta ERC4626 caution/warning from OpenZepplin on donation attack Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in constructor - IOFT.decimalConversionRate() Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org> Co-authored-by: Blockchain Warlock <39101443+TRileySchwarz@users.noreply.github.com>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org> Co-authored-by: Shankar Subramanian <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org> Co-authored-by: Blockchain Warlock <39101443+TRileySchwarz@users.noreply.github.com> Co-authored-by: Krak <krak@layerzerolabs.org>
0e8941f to
c39c35e
Compare
Signed-off-by: shankar <shankar@layerzerolabs.org> Co-authored-by: Blockchain Warlock <39101443+TRileySchwarz@users.noreply.github.com> Co-authored-by: Matthew Krak <krak@layerzerolabs.org>
All PRs related to OVaults will be merged into this branch and treat it as the
mainbranch.Post audit this branch will be merged into
main