From fba24717cbe4434873b05fc5a504e75a19cc6823 Mon Sep 17 00:00:00 2001 From: Tlazypanda Date: Thu, 26 Jun 2025 13:42:01 +0530 Subject: [PATCH] fix bug in cli version check --- packages/devtools-move/tasks/move/utils/config.ts | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/packages/devtools-move/tasks/move/utils/config.ts b/packages/devtools-move/tasks/move/utils/config.ts index aa37714413..737a132e59 100644 --- a/packages/devtools-move/tasks/move/utils/config.ts +++ b/packages/devtools-move/tasks/move/utils/config.ts @@ -356,11 +356,15 @@ function greaterThanOrEqualTo(installed: string, required: string): boolean { const requiredParts = required.split('.').map(Number) for (let i = 0; i < 3; i++) { - if (installedParts[i] < requiredParts[i]) { + if (installedParts[i] > requiredParts[i]) { + return true + } + else if (installedParts[i] < requiredParts[i]){ + return false } } - // all parts are greater than or equal to the required version + // all parts are equal to the required version return true } @@ -372,7 +376,11 @@ function lessThanOrEqualTo(installed: string, required: string): boolean { if (installedParts[i] > requiredParts[i]) { return false } + else if (installedParts[i] < requiredParts[i]){ + + return true + } } - // all parts are less than or equal to the required version + // all parts are equal to the required version return true }