Skip to content

fix bug in cli version check #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tlazypanda wants to merge 1 commit into from
Closed

fix bug in cli version check #1592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/devtools-move/tasks/move/utils/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,11 +356,15 @@ function greaterThanOrEqualTo(installed: string, required: string): boolean {
const requiredParts = required.split('.').map(Number)

for (let i = 0; i < 3; i++) {
if (installedParts[i] < requiredParts[i]) {
if (installedParts[i] > requiredParts[i]) {
return true
}
else if (installedParts[i] < requiredParts[i]){

return false
}
}
// all parts are greater than or equal to the required version
// all parts are equal to the required version
return true
}

Expand All @@ -372,7 +376,11 @@ function lessThanOrEqualTo(installed: string, required: string): boolean {
if (installedParts[i] > requiredParts[i]) {
return false
}
else if (installedParts[i] < requiredParts[i]){

return true
}
}
// all parts are less than or equal to the required version
// all parts are equal to the required version
return true
}