Skip to content

INT-406: fix move CLI version checks - #1593

Merged
AlexanderLiteplo merged 4 commits into
mainfrom
fix/move-version-check
Jul 2, 2025
Merged

INT-406: fix move CLI version checks#1593
AlexanderLiteplo merged 4 commits into
mainfrom
fix/move-version-check

Conversation

@DanL0

@DanL0 DanL0 commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Based on: #1592

The version check for the CLI was wrong, as flagged by the original PR creator it was showing that 7.5.0 isn't greater or equal than 6.0.2.

This PR fixes the problem and also adds tests and enables running them in CI.

@DanL0 DanL0 changed the title fix move CLI version checks INT-406: fix move CLI version checks Jun 26, 2025
@shankars99

Copy link
Copy Markdown
Collaborator

@AlexanderLiteplo and I had a discussion about this.

So the entire stack has been tested at 6.0.1 - oft, oapp, endpoint, libraries, etc. So we don't know if using v7 would break anything or even if a compile and test work the bytecode is different and it doesnt play well with our systems.

As such we think instead of just allowing anyone over the version of 6.0.1 to build, we guarantee the working at 6.0.1 and anything over that we info prompt them something along the lines of "something might be different and we cant guarantee equivalence or provide support if a re-write is required to be compliant with a higher version"

@DanL0

DanL0 commented Jun 26, 2025

Copy link
Copy Markdown
Contributor Author

Got it. I'm assuming we can close this PR then and we can open new PR for adding warning @shankars99 ?

@AlexanderLiteplo

Copy link
Copy Markdown
Contributor

Good catch Dan, I think we should merge this as that is indeed a bug.

@AlexanderLiteplo

Copy link
Copy Markdown
Contributor

We can add a warning in a new PR or just add a warning to this one.

@AlexanderLiteplo

Copy link
Copy Markdown
Contributor

I recently tested with version over 7 and everything worked

@AlexanderLiteplo AlexanderLiteplo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis should be merged, and then we can put a warning within the CLI later. For now the Readme reccomends 6.0.1 which is enough of a warning. But currently there is a blocked partner so lets get this merged asap.

@AlexanderLiteplo

Copy link
Copy Markdown
Contributor

mvm going to just quickly add a warning when its not 6.0.1

…ended versions in config utility. Add corresponding test case for warning message format.
@AlexanderLiteplo

Copy link
Copy Markdown
Contributor
image

Added warning

cc: @shankars99 @DanL0

@AlexanderLiteplo

Copy link
Copy Markdown
Contributor

added operation cancel option
image

@AlexanderLiteplo
AlexanderLiteplo merged commit 6a5d25e into main Jul 2, 2025
11 checks passed
@AlexanderLiteplo
AlexanderLiteplo deleted the fix/move-version-check branch July 2, 2025 18:20
shankars99 pushed a commit that referenced this pull request Jul 20, 2025
Co-authored-by: alexanderliteplo <alexanderliteplo@gmail.com>
mattsse pushed a commit to mattsse/devtools that referenced this pull request Aug 12, 2025
Co-authored-by: alexanderliteplo <alexanderliteplo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants