INT-402: mint/burn native oft adapter upgradeable - #1595
Closed
ravinagill15 wants to merge 2 commits into
Closed
Conversation
St0rmBr3w
reviewed
Jul 2, 2025
St0rmBr3w
left a comment
St0rmBr3w
left a comment
Contributor
There was a problem hiding this comment.
Is there a reason we're adding this contract to the package? Why not just inherit it as a not abstract contract?
Contributor
Author
|
@St0rmBr3w Yeah that's a great point since this is a ready to use contract. I marked it as abstract to follow the pattern of the other existing upgradeable implementations we have like OFTAdapterUpgradeable Regardless, this PR will be closed because Plume has stated upgradeable contracts are not a hard requirement for them. Furthermore, since no liquidity will be locked inside a mint/burn contract, a new mint/burn contract can easily be deployed and wired into the mesh |
ravinagill15
deleted the
ravina/int-402-mint-burn-native-oft-adapter-upgradeable
branch
July 2, 2025 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
Todo