audit patches + improvement - #1600
Merged
Merged
Conversation
Signed-off-by: shankar <shankar@layerzerolabs.org>
…yWithSwap Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
gpersoon
reviewed
Jul 4, 2025
gpersoon
reviewed
Jul 4, 2025
gpersoon
reviewed
Jul 4, 2025
gpersoon
reviewed
Jul 4, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
… grouping similar functions Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
gpersoon
reviewed
Jul 5, 2025
gpersoon
reviewed
Jul 5, 2025
gpersoon
reviewed
Jul 5, 2025
gpersoon
reviewed
Jul 5, 2025
gpersoon
reviewed
Jul 5, 2025
gpersoon
reviewed
Jul 5, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org>
… fails Signed-off-by: shankar <shankar@layerzerolabs.org>
…UND address Signed-off-by: shankar <shankar@layerzerolabs.org>
…ebitView() Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
gpersoon
reviewed
Jul 6, 2025
gpersoon
reviewed
Jul 6, 2025
gpersoon
reviewed
Jul 6, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
shankars99
marked this pull request as ready for review
July 8, 2025 17:31
shankars99
added a commit
that referenced
this pull request
Jul 20, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org>
shankars99
added a commit
that referenced
this pull request
Jul 20, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org>
shankars99
added a commit
that referenced
this pull request
Jul 25, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org> feat: ovault composer (#1583) Signed-off-by: shankar <shankar@layerzerolabs.org> rename: ovault-composer-evm to ovault-evm (#1587) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault examples (#1588) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault example changes (#1590) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault cleanup #1 (#1594) Signed-off-by: shankar <shankar@layerzerolabs.org> audit patches + improvement (#1600) Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/improvements (#1603) Signed-off-by: shankar <shankar@layerzerolabs.org> example to match package Signed-off-by: shankar <shankar@layerzerolabs.org> virtual on _executeOVaultAction Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/source is hub (#1606) Signed-off-by: shankar <shankar@layerzerolabs.org> fix: deposit actions (#1610) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault - standardize event emitted during entry of failed state in lzCompose (#1611) Signed-off-by: shankar <shankar@layerzerolabs.org> update to match package Signed-off-by: shankar <shankar@layerzerolabs.org> issue-5: skip removeDust() on slippage check when dstEid=hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-9: token.safeTransfer(..args) instead of transfer Signed-off-by: shankar <shankar@layerzerolabs.org> issue-4: refuse msg.value on proxySend() when dstEid is the hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-12: remove duplicated safeERC20 import and library usage Signed-off-by: shankar <shankar@layerzerolabs.org> issue-13: initialize() for upgradeable Signed-off-by: shankar <shankar@layerzerolabs.org> issue-14: remove unused interface errors Signed-off-by: shankar <shankar@layerzerolabs.org> to match packages Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in retry() Signed-off-by: shankar <shankar@layerzerolabs.org> copy-pasta ERC4626 caution/warning from OpenZepplin on donation attack Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in constructor - IOFT.decimalConversionRate() Signed-off-by: shankar <shankar@layerzerolabs.org>
shankars99
added a commit
that referenced
this pull request
Jul 25, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org> feat: ovault composer (#1583) Signed-off-by: shankar <shankar@layerzerolabs.org> rename: ovault-composer-evm to ovault-evm (#1587) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault examples (#1588) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault example changes (#1590) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault cleanup #1 (#1594) Signed-off-by: shankar <shankar@layerzerolabs.org> audit patches + improvement (#1600) Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/improvements (#1603) Signed-off-by: shankar <shankar@layerzerolabs.org> example to match package Signed-off-by: shankar <shankar@layerzerolabs.org> virtual on _executeOVaultAction Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/source is hub (#1606) Signed-off-by: shankar <shankar@layerzerolabs.org> fix: deposit actions (#1610) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault - standardize event emitted during entry of failed state in lzCompose (#1611) Signed-off-by: shankar <shankar@layerzerolabs.org> update to match package Signed-off-by: shankar <shankar@layerzerolabs.org> issue-5: skip removeDust() on slippage check when dstEid=hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-9: token.safeTransfer(..args) instead of transfer Signed-off-by: shankar <shankar@layerzerolabs.org> issue-4: refuse msg.value on proxySend() when dstEid is the hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-12: remove duplicated safeERC20 import and library usage Signed-off-by: shankar <shankar@layerzerolabs.org> issue-13: initialize() for upgradeable Signed-off-by: shankar <shankar@layerzerolabs.org> issue-14: remove unused interface errors Signed-off-by: shankar <shankar@layerzerolabs.org> to match packages Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in retry() Signed-off-by: shankar <shankar@layerzerolabs.org> copy-pasta ERC4626 caution/warning from OpenZepplin on donation attack Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in constructor - IOFT.decimalConversionRate() Signed-off-by: shankar <shankar@layerzerolabs.org>
shankars99
added a commit
that referenced
this pull request
Aug 7, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org> feat: ovault composer (#1583) Signed-off-by: shankar <shankar@layerzerolabs.org> rename: ovault-composer-evm to ovault-evm (#1587) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault examples (#1588) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault example changes (#1590) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault cleanup #1 (#1594) Signed-off-by: shankar <shankar@layerzerolabs.org> audit patches + improvement (#1600) Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/improvements (#1603) Signed-off-by: shankar <shankar@layerzerolabs.org> example to match package Signed-off-by: shankar <shankar@layerzerolabs.org> virtual on _executeOVaultAction Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/source is hub (#1606) Signed-off-by: shankar <shankar@layerzerolabs.org> fix: deposit actions (#1610) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault - standardize event emitted during entry of failed state in lzCompose (#1611) Signed-off-by: shankar <shankar@layerzerolabs.org> update to match package Signed-off-by: shankar <shankar@layerzerolabs.org> issue-5: skip removeDust() on slippage check when dstEid=hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-9: token.safeTransfer(..args) instead of transfer Signed-off-by: shankar <shankar@layerzerolabs.org> issue-4: refuse msg.value on proxySend() when dstEid is the hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-12: remove duplicated safeERC20 import and library usage Signed-off-by: shankar <shankar@layerzerolabs.org> issue-13: initialize() for upgradeable Signed-off-by: shankar <shankar@layerzerolabs.org> issue-14: remove unused interface errors Signed-off-by: shankar <shankar@layerzerolabs.org> to match packages Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in retry() Signed-off-by: shankar <shankar@layerzerolabs.org> copy-pasta ERC4626 caution/warning from OpenZepplin on donation attack Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in constructor - IOFT.decimalConversionRate() Signed-off-by: shankar <shankar@layerzerolabs.org>
St0rmBr3w
pushed a commit
that referenced
this pull request
Aug 7, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org> feat: ovault composer (#1583) Signed-off-by: shankar <shankar@layerzerolabs.org> rename: ovault-composer-evm to ovault-evm (#1587) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault examples (#1588) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault example changes (#1590) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault cleanup #1 (#1594) Signed-off-by: shankar <shankar@layerzerolabs.org> audit patches + improvement (#1600) Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/improvements (#1603) Signed-off-by: shankar <shankar@layerzerolabs.org> example to match package Signed-off-by: shankar <shankar@layerzerolabs.org> virtual on _executeOVaultAction Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/source is hub (#1606) Signed-off-by: shankar <shankar@layerzerolabs.org> fix: deposit actions (#1610) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault - standardize event emitted during entry of failed state in lzCompose (#1611) Signed-off-by: shankar <shankar@layerzerolabs.org> update to match package Signed-off-by: shankar <shankar@layerzerolabs.org> issue-5: skip removeDust() on slippage check when dstEid=hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-9: token.safeTransfer(..args) instead of transfer Signed-off-by: shankar <shankar@layerzerolabs.org> issue-4: refuse msg.value on proxySend() when dstEid is the hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-12: remove duplicated safeERC20 import and library usage Signed-off-by: shankar <shankar@layerzerolabs.org> issue-13: initialize() for upgradeable Signed-off-by: shankar <shankar@layerzerolabs.org> issue-14: remove unused interface errors Signed-off-by: shankar <shankar@layerzerolabs.org> to match packages Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in retry() Signed-off-by: shankar <shankar@layerzerolabs.org> copy-pasta ERC4626 caution/warning from OpenZepplin on donation attack Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in constructor - IOFT.decimalConversionRate() Signed-off-by: shankar <shankar@layerzerolabs.org>
shankars99
added a commit
that referenced
this pull request
Aug 8, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org> feat: ovault composer (#1583) Signed-off-by: shankar <shankar@layerzerolabs.org> rename: ovault-composer-evm to ovault-evm (#1587) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault examples (#1588) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault example changes (#1590) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault cleanup #1 (#1594) Signed-off-by: shankar <shankar@layerzerolabs.org> audit patches + improvement (#1600) Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/improvements (#1603) Signed-off-by: shankar <shankar@layerzerolabs.org> example to match package Signed-off-by: shankar <shankar@layerzerolabs.org> virtual on _executeOVaultAction Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/source is hub (#1606) Signed-off-by: shankar <shankar@layerzerolabs.org> fix: deposit actions (#1610) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault - standardize event emitted during entry of failed state in lzCompose (#1611) Signed-off-by: shankar <shankar@layerzerolabs.org> update to match package Signed-off-by: shankar <shankar@layerzerolabs.org> issue-5: skip removeDust() on slippage check when dstEid=hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-9: token.safeTransfer(..args) instead of transfer Signed-off-by: shankar <shankar@layerzerolabs.org> issue-4: refuse msg.value on proxySend() when dstEid is the hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-12: remove duplicated safeERC20 import and library usage Signed-off-by: shankar <shankar@layerzerolabs.org> issue-13: initialize() for upgradeable Signed-off-by: shankar <shankar@layerzerolabs.org> issue-14: remove unused interface errors Signed-off-by: shankar <shankar@layerzerolabs.org> to match packages Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in retry() Signed-off-by: shankar <shankar@layerzerolabs.org> copy-pasta ERC4626 caution/warning from OpenZepplin on donation attack Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in constructor - IOFT.decimalConversionRate() Signed-off-by: shankar <shankar@layerzerolabs.org>
shankars99
added a commit
that referenced
this pull request
Aug 9, 2025
Signed-off-by: shankar <shankar@layerzerolabs.org> feat: ovault composer (#1583) Signed-off-by: shankar <shankar@layerzerolabs.org> rename: ovault-composer-evm to ovault-evm (#1587) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault examples (#1588) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault example changes (#1590) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault cleanup #1 (#1594) Signed-off-by: shankar <shankar@layerzerolabs.org> audit patches + improvement (#1600) Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/improvements (#1603) Signed-off-by: shankar <shankar@layerzerolabs.org> example to match package Signed-off-by: shankar <shankar@layerzerolabs.org> virtual on _executeOVaultAction Signed-off-by: shankar <shankar@layerzerolabs.org> Ovault/source is hub (#1606) Signed-off-by: shankar <shankar@layerzerolabs.org> fix: deposit actions (#1610) Signed-off-by: shankar <shankar@layerzerolabs.org> ovault - standardize event emitted during entry of failed state in lzCompose (#1611) Signed-off-by: shankar <shankar@layerzerolabs.org> update to match package Signed-off-by: shankar <shankar@layerzerolabs.org> issue-5: skip removeDust() on slippage check when dstEid=hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-9: token.safeTransfer(..args) instead of transfer Signed-off-by: shankar <shankar@layerzerolabs.org> issue-4: refuse msg.value on proxySend() when dstEid is the hub Signed-off-by: shankar <shankar@layerzerolabs.org> issue-12: remove duplicated safeERC20 import and library usage Signed-off-by: shankar <shankar@layerzerolabs.org> issue-13: initialize() for upgradeable Signed-off-by: shankar <shankar@layerzerolabs.org> issue-14: remove unused interface errors Signed-off-by: shankar <shankar@layerzerolabs.org> to match packages Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in retry() Signed-off-by: shankar <shankar@layerzerolabs.org> copy-pasta ERC4626 caution/warning from OpenZepplin on donation attack Signed-off-by: shankar <shankar@layerzerolabs.org> issue-11: remove duplication in constructor - IOFT.decimalConversionRate() Signed-off-by: shankar <shankar@layerzerolabs.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to the audit report