[INT-361]: call is enforced for gnosis safe batch txs - #1601
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enforces that only CALL operations are used when creating Gnosis Safe batch transactions, removes an unused assertion import, and updates the changeset for a patch release.
- Removed the
assertimport and the empty-array assertion insignAndSendBatch - Added
onlyCalls: trueto the Safe transaction creation call - Updated the
.changesetto bump the package with this fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devtools-evm/src/signer/sdk.ts | Removed unused assert, added onlyCalls: true, and cast to any |
| .changeset/tiny-trainers-love.md | Bumped package patch version with description of the fix |
Comments suppressed due to low confidence (1)
packages/devtools-evm/src/signer/sdk.ts:99
- Consider adding a unit or integration test for
signAndSendBatchthat verifiesonlyCallsis enforced and that delegate calls are rejected.
async signAndSendBatch(transactions: OmniTransaction[]): Promise<OmniTransactionResponse> {
ItsAdel
commented
Jul 4, 2025
ravinagill15
approved these changes
Jul 7, 2025
EWCunha
approved these changes
Jul 7, 2025
EWCunha
left a comment
Contributor
There was a problem hiding this comment.
Well done! You handled that like a pro. A caffeinated, highly competent, borderline magical pro.
AlexanderLiteplo
left a comment
Contributor
There was a problem hiding this comment.
great PR nice work
shankars99
pushed a commit
that referenced
this pull request
Jul 20, 2025
mattsse
pushed a commit
to mattsse/devtools
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this entire time
LZ_ENABLE_EXPERIMENTAL_BATCHED_SENDwas available which lets users send batch safe txs.When testing it out, I ran into issue
Operation DELEGATE_CALL is not allowedQuick one liner fix to enforce only Calls and retried everything and it seemed to work:
Successful multisig batch proposal + signing when running the wire command to update config: https://app.safe.global/transactions/tx?id=multisig_0x1fBd62569885EDc6b757f6C27699F30aB6b0A05a_0x26fd7e96c35a7562ce9d50a85fe16c1419b209858fe90634b0a721c989da2903&safe=bnb:0x1fBd62569885EDc6b757f6C27699F30aB6b0A05a
output when command was run:
LZ_ENABLE_EXPERIMENTAL_BATCHED_SEND=1 npx hardhat lz:oapp:wire --oapp-config layerzero.config.ts --safe --log-level debug