Skip to content

DEVREL-580 oft-solana: specify exact message value for when transferring to Solana - #1616

Merged
nazreen merged 6 commits into
mainfrom
solana-message-value
Jul 25, 2025
Merged

DEVREL-580 oft-solana: specify exact message value for when transferring to Solana#1616
nazreen merged 6 commits into
mainfrom
solana-message-value

Conversation

@nazreen

@nazreen nazreen commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@nazreen nazreen changed the title oft-solana: specify exact message value for when transferring to Solana DEVREL-580 oft-solana: specify exact message value for when transferring to Solana Jul 14, 2025
@nazreen
nazreen requested review from DanL0, St0rmBr3w and Copilot July 14, 2025 23:41

This comment was marked as outdated.

@St0rmBr3w St0rmBr3w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add to the README a subsection on this under wiring or enforced options in particular? This can highlight @arekLZ's note that teams can also check via their frontend whether the receiver has initialized this account ahead of time and pass via extra options.

This enforced value is purely for ensuring value delivery works for all UIs and uses, whereas extra options is strictly for if you want the minimum possible via your UI.

@nazreen

nazreen commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

@St0rmBr3w

Can we also add to the README a subsection on this under wiring or enforced options in particular? This can highlight @arekLZ's note that teams can also check via their frontend whether the receiver has initialized this account ahead of time and pass via extra options.

Best place for this is in the docs under the Solana section. Then in this LZ Config, it links to there. Will be working on that PR tomorrow.

@nazreen
nazreen requested a review from Copilot July 24, 2025 15:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Solana configuration in the LayerZero OFT example to use explicit constants with detailed documentation for gas limits and rent values when transferring tokens to Solana.

  • Replaces magic numbers with named constants for compute unit limits and SPL token account rent values
  • Adds comprehensive documentation explaining the rent mechanism for Solana token accounts
  • Provides guidance for Token2022 accounts that may require different rent values

Comment thread examples/oft-solana/layerzero.config.ts

@St0rmBr3w St0rmBr3w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nazreen
nazreen merged commit 368b4b4 into main Jul 25, 2025
12 checks passed
@nazreen
nazreen deleted the solana-message-value branch July 25, 2025 09:15
mattsse pushed a commit to mattsse/devtools that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants