Skip to content

build: fix foundryup line - #1854

Merged
shankars99 merged 8 commits into
mainfrom
attempt-build-foundry-fix
Nov 29, 2025
Merged

build: fix foundryup line#1854
shankars99 merged 8 commits into
mainfrom
attempt-build-foundry-fix

Conversation

@nazreen

@nazreen nazreen commented Nov 29, 2025

Copy link
Copy Markdown
Contributor

Diagnosis

foundryup -u 1.4.4.

results in version 1.4.4 not installed

refer to the failing run of build base image on main: https://github.com/LayerZero-Labs/devtools/actions/runs/19776463219/job/56669775441#step:3:4296

turns out,

we need to do

foundryup -u v1.4.4.

that v is important.

basically, foundryup -u just looks for the folder under FOUNDRY_DIR named exactly what you pass it
and if we installed 1.4.4. the directory would be FOUNDRY_DIR/versions/v1.4.4
so doing only foundryup -u 1.4.4. would mean it looks for FOUNDRY_DIR/versions/1.4.4 which does not exist

Proof of Successful Build Image Run

https://github.com/LayerZero-Labs/devtools/actions/runs/19777418103

Proof of successful CI with new image

#1856

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@nazreen nazreen mentioned this pull request Nov 29, 2025
@nazreen

nazreen commented Nov 29, 2025

Copy link
Copy Markdown
Contributor Author

This can be merged if #1856 is successful

@nazreen

nazreen commented Nov 29, 2025

Copy link
Copy Markdown
Contributor Author

CI with new image succeeds: #1856

@nazreen nazreen changed the title fix foundryup line build: fix foundryup line Nov 29, 2025
@nazreen
nazreen marked this pull request as ready for review November 29, 2025 12:07
@fabianhug
fabianhug self-requested a review November 29, 2025 20:50
@shankars99
shankars99 merged commit 28f9c6f into main Nov 29, 2025
37 checks passed
@shankars99
shankars99 deleted the attempt-build-foundry-fix branch November 29, 2025 22:28
@nazreen

nazreen commented Nov 30, 2025

Copy link
Copy Markdown
Contributor Author

building from latest main after this PR's merge: https://github.com/LayerZero-Labs/devtools/actions/runs/19790604266
success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants