Skip to content

feat: codeql workflow for ts and rust - #1864

Merged
shankars99 merged 7 commits into
mainfrom
ci/codeql-workflow
Dec 10, 2025
Merged

feat: codeql workflow for ts and rust#1864
shankars99 merged 7 commits into
mainfrom
ci/codeql-workflow

Conversation

@shankars99

@shankars99 shankars99 commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

CodeQL extension does not run on fork prs into devtools. This workflow yaml should effectively replace the extension.

Also took the liberty to add in:

  1. Dockerfile scanning
  2. Shell script scanning

ontop of codeql's js-ts and rust

It also runs weekly scans on main

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@socket-security

socket-security Bot commented Dec 8, 2025

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedgithub/​ludeeus/​action-shellcheck@​00cae500b08a931fb5698e11e79bfbd38e612a3810010093100100
Addedgithub/​hadolint/​hadolint-action@​54c9adbab1582c2ef04b2016b760714a4bfde3cf10010096100100

View full report

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@shankars99
shankars99 marked this pull request as ready for review December 8, 2025 07:14
@shankars99
shankars99 requested a review from Copilot December 8, 2025 07:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a comprehensive security scanning workflow to replace the GitHub CodeQL extension, which doesn't support fork PRs. The workflow adds CodeQL analysis for TypeScript/JavaScript and Rust, plus additional security scanning for Dockerfiles and shell scripts, with weekly automated scans on the main branch.

Key Changes:

  • CodeQL security analysis for JavaScript/TypeScript and Rust with extended security queries
  • Hadolint scanning for Dockerfile security and best practices
  • ShellCheck integration for shell script linting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/codeql.yaml Outdated
Comment thread .github/workflows/codeql.yaml Outdated
@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

ravinagill15
ravinagill15 previously approved these changes Dec 8, 2025

@ravinagill15 ravinagill15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments / clarifications

Comment thread .github/workflows/codeql.yaml Outdated
Comment thread .github/workflows/codeql.yml
@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

St0rmBr3w
St0rmBr3w previously approved these changes Dec 8, 2025

@St0rmBr3w St0rmBr3w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

ravinagill15
ravinagill15 previously approved these changes Dec 8, 2025
@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Signed-off-by: shankar <shankar@layerzerolabs.org>
@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@St0rmBr3w St0rmBr3w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shankars99
shankars99 enabled auto-merge December 10, 2025 01:40

# Cancel in-progress runs when a new commit is pushed
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will only cancel in-progress runs in a same PR.

I'm guessing it's ok.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah thats what we wanna do

@shankars99
shankars99 added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit 7303538 Dec 10, 2025
18 checks passed
@shankars99
shankars99 deleted the ci/codeql-workflow branch December 10, 2025 02:08
@shankars99 shankars99 self-assigned this Dec 17, 2025
@shankars99 shankars99 added the ready to review in a state where CI passes and the PR is quite upto date with main and you need reviews label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to review in a state where CI passes and the PR is quite upto date with main and you need reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants