-
Notifications
You must be signed in to change notification settings - Fork 280
feat: codeql workflow for ts and rust #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
684e496
feat: codeql workflow for ts and rust
shankars99 fdffe68
chore: add dockerfile and shellscript
shankars99 75b4077
version tagging actions
shankars99 79cf1e0
chore: remove redundant permissions
shankars99 b4f1054
chore: create a CodeQL workflow to match the required status check
shankars99 08bf4b6
rename to match what codeql expect
shankars99 d48ad27
workflow name codeql
shankars99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| # .-.-. .-.-. .-.-. .-.-. .-.-. .-.-. .-.-. .-.- .-.-. .-.-. .-.- | ||
| # / / \ \ / / \ \ / / \ \ / / \ \ / / \ \ / / \ \ / / \ \ / / \ / / \ \ / / \ \ / / \ | ||
| # `-' `-`-' `-`-' `-`-' `-`-' `-`-' `-`-' `-' `-`-' `-`-' `-`-' | ||
| # | ||
| # CodeQL | ||
| # | ||
| # This workflow replaces the GitHub CodeQL extension to support fork PRs. | ||
| # The extension doesn't trigger on fork PRs due to security restrictions. | ||
| # This workflow uses the pull_request event which works for all PRs. | ||
| # | ||
| # .-.-. .-.-. .-.-. .-.-. .-.-. .-.-. .-.-. .-.- .-.-. .-.-. .-.- | ||
| # / / \ \ / / \ \ / / \ \ / / \ \ / / \ \ / / \ \ / / \ \ / / \ / / \ \ / / \ \ / / \ | ||
| # `-' `-`-' `-`-' `-`-' `-`-' `-`-' `-`-' `-`-' `-' `-`-' `-`-' | ||
| name: CodeQL | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - develop | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - develop | ||
| merge_group: | ||
| # Required for GitHub merge queue | ||
| branches: | ||
| - main | ||
| - develop | ||
| schedule: | ||
| # Run weekly security scans every Monday at midnight UTC | ||
| - cron: '0 0 * * 1' | ||
|
|
||
| # Cancel in-progress runs when a new commit is pushed | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | ||
| cancel-in-progress: true | ||
|
|
||
| # Minimal permissions for fork PRs | ||
| # Results are uploaded to Security tab and posted as checks | ||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| actions: read | ||
|
|
||
| jobs: | ||
| analyze: | ||
| name: CodeQL Analysis | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| language: ['javascript-typescript', 'rust'] | ||
|
|
||
| # Skip autobuild - CodeQL can analyze source code directly | ||
| # No need to compile or install dependencies for static analysis | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: 'true' | ||
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v4 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| build-mode: none | ||
| # Use default queries plus security-extended for more coverage | ||
| queries: security-extended | ||
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@v4 | ||
| with: | ||
| category: "/language:${{ matrix.language }}" | ||
|
|
||
| dockerfile: | ||
| name: Dockerfile Lint | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| needs: analyze | ||
|
ravinagill15 marked this conversation as resolved.
|
||
|
|
||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Run Hadolint | ||
| uses: hadolint/hadolint-action@v3.1.0 | ||
| with: | ||
| dockerfile: Dockerfile | ||
| format: sarif | ||
| output-file: hadolint.sarif | ||
| no-fail: true | ||
|
|
||
| - name: Upload Hadolint results | ||
| uses: github/codeql-action/upload-sarif@v4 | ||
| if: always() | ||
| with: | ||
| sarif_file: hadolint.sarif | ||
| category: "hadolint" | ||
|
|
||
| # Note: ShellCheck action doesn't natively support SARIF output | ||
| # Results will appear in workflow logs | ||
| shellcheck: | ||
| name: Shell Script Lint | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| needs: analyze | ||
|
|
||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Run ShellCheck | ||
| uses: ludeeus/action-shellcheck@2.0.0 | ||
| with: | ||
| scandir: '.' | ||
| format: gcc | ||
| severity: warning | ||
| continue-on-error: true | ||
|
|
||
| # Final status check job for backwards compatibility with the old CodeQL workflow | ||
| CodeQL: | ||
| name: CodeQL | ||
| runs-on: ubuntu-latest | ||
| needs: [analyze, dockerfile, shellcheck] | ||
| if: always() | ||
|
|
||
| steps: | ||
| - name: Check all jobs succeeded | ||
| run: | | ||
| if [ "${{ needs.analyze.result }}" != "success" ]; then | ||
| echo "CodeQL analysis failed" | ||
| exit 1 | ||
| fi | ||
| if [ "${{ needs.dockerfile.result }}" != "success" ]; then | ||
| echo "Dockerfile lint failed" | ||
| exit 1 | ||
| fi | ||
| if [ "${{ needs.shellcheck.result }}" != "success" ]; then | ||
| echo "ShellCheck lint failed" | ||
| exit 1 | ||
| fi | ||
| echo "All security checks passed!" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will only cancel in-progress runs in a same PR.
I'm guessing it's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah thats what we wanna do