Skip to content

added navigation to profile via people page#99

Merged
shoshannaTM merged 2 commits into
masterfrom
shosh-onboarding
Sep 16, 2025
Merged

added navigation to profile via people page#99
shoshannaTM merged 2 commits into
masterfrom
shosh-onboarding

Conversation

@shoshannaTM

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/app/pages/people/people.page.ts Outdated
})
export class PeoplePage implements OnInit, OnDestroy {

//added self query the same as done on profile page

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these comments

Comment thread src/app/pages/tabs/tabs.page.html Outdated
<ion-tab-button tab="notifications" *ngIf="environment.featureFlags.notificationsPage">
<ion-icon color="dark" name="notifications"></ion-icon>
</ion-tab-button>
<!-- Why have this here? isMobile will always be false because it's in the not mobile block.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch let's remove this.

@shoshannaTM shoshannaTM merged commit 1857d84 into master Sep 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants