iterative Tarjan SCC to avoid stack overflow on large graphs#49
Open
LdDl wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recursive Tarjan risks uncontrolled Go stack growth on city-scale graphs with deep DFS chains (100k+ vertices). Iterative version bounds memory explicitly so I've replaced recursive
strongConnectwith iterative version using explicit call stack:strongConnectinvocationsgraph has 40k vertices: time and allocs are changed barely. Also +3.8MB is the one-time cost of the flat adjacency buffer - negligible compared to the graph itself.