Skip to content

Commit 3d2cf4e

Browse files
committed
Fix: Return SuccessResponse for 204 No Content instead of ErrorResponse
1 parent 1126bd2 commit 3d2cf4e

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

leakix/async_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ async def _get(
7171
elif r.status_code == 429:
7272
return RateLimitResponse(response=r)
7373
elif r.status_code == 204:
74-
return ErrorResponse(response=r, response_json=[], status_code=200)
74+
return SuccessResponse(response=r, response_json=[])
7575
else:
7676
return ErrorResponse(response=r, response_json=r.json())
7777

@@ -160,7 +160,7 @@ async def bulk_export(
160160
elif r.status_code == 429:
161161
return RateLimitResponse(response=r)
162162
elif r.status_code == 204:
163-
return ErrorResponse(response=r, response_json=[], status_code=200)
163+
return SuccessResponse(response=r, response_json=[])
164164
else:
165165
await r.aread()
166166
return ErrorResponse(response=r, response_json=r.json())

leakix/client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def _get(self, url: str, params: dict[str, Any] | None) -> AbstractResponse:
3535
elif r.status_code == 429:
3636
return RateLimitResponse(response=r)
3737
elif r.status_code == 204:
38-
return ErrorResponse(response=r, response_json=[], status_code=200)
38+
return SuccessResponse(response=r, response_json=[])
3939
else:
4040
return ErrorResponse(response=r, response_json=r.json())
4141

@@ -137,7 +137,7 @@ def bulk_export(
137137
elif r.status_code == 429:
138138
return RateLimitResponse(response=r)
139139
elif r.status_code == 204:
140-
return ErrorResponse(response=r, response_json=[], status_code=200)
140+
return SuccessResponse(response=r, response_json=[])
141141
else:
142142
return ErrorResponse(response=r, response_json=r.json())
143143

@@ -171,7 +171,7 @@ def bulk_service(
171171
elif r.status_code == 429:
172172
return RateLimitResponse(response=r)
173173
elif r.status_code == 204:
174-
return ErrorResponse(response=r, response_json=[], status_code=200)
174+
return SuccessResponse(response=r, response_json=[])
175175
else:
176176
return ErrorResponse(response=r, response_json=r.json())
177177

0 commit comments

Comments
 (0)